Introduce "underlying types" to abstract XFA differences.

Introduce "underlying types" to abstract XFA differences.

See the comment in fsdk_define.h.  Also tidy up a bit,
and remove dead DeletePages().  This should help us
match master more closely (given corresponding changes
on the master side).

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/50d12ada784ad3ba3f9ed6935d59f1ce828695e5

[Tom Sepez, 2015-11-24 00:23:27]

Description was changed from

==========
Introduce "underlying types" to abstract XFA differences.
==========

to

==========
Introduce "underlying types" to abstract XFA differences.

See the comment in fsdk_define.h.  Also tidy up a bit,
and remove dead DeletePages().  This should help us
match master more closely (given corresponding changes
on the master side).
==========

[Tom Sepez, 2015-11-24 00:23:27]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-11-24 00:23:33]

https://codereview.chromium.org/1473503002/diff/1/fpdfsdk/src/fsdk_baseannot.cpp
File fpdfsdk/src/fsdk_baseannot.cpp (right):

https://codereview.chromium.org/1473503002/diff/1/fpdfsdk/src/fsdk_baseannot....
fpdfsdk/src/fsdk_baseannot.cpp:985: return GetPDFXFAPage();
e.g., in master this changes to GetPDFPage().

[Tom Sepez, 2015-11-24 00:25:36]

Lei, for review, part of the work to make fpdfsdk have fewer diff lines.

[Lei Zhang, 2015-11-24 00:45:14]

https://codereview.chromium.org/1473503002/diff/1/fpdfsdk/include/fsdk_basean...
File fpdfsdk/include/fsdk_baseannot.h (right):

https://codereview.chromium.org/1473503002/diff/1/fpdfsdk/include/fsdk_basean...
fpdfsdk/include/fsdk_baseannot.h:18: #include "fx_systemhandler.h"
this comes last, might as well make it fpdfsdk/include/fx_systemhandler.h

https://codereview.chromium.org/1473503002/diff/1/fpdfsdk/include/fsdk_mgr.h
File fpdfsdk/include/fsdk_mgr.h (right):

https://codereview.chromium.org/1473503002/diff/1/fpdfsdk/include/fsdk_mgr.h#...
fpdfsdk/include/fsdk_mgr.h:488: CPDFXFA_Document* GetXFADocument() const {
return m_pDoc; }
Should we even bother with this? Can we just use GetUnderlyingDocument() even in
XFA-only code? I'm not leaning one way or the other, just wondering.

https://codereview.chromium.org/1473503002/diff/1/fpdfsdk/src/fsdk_annothandl...
File fpdfsdk/src/fsdk_annothandler.cpp (right):

https://codereview.chromium.org/1473503002/diff/1/fpdfsdk/src/fsdk_annothandl...
fpdfsdk/src/fsdk_annothandler.cpp:641: if (sSubType == BFFT_SIGNATURE) {
BTW, this file is filllllllled with these.

[Tom Sepez, 2015-11-24 00:57:53]

https://codereview.chromium.org/1473503002/diff/1/fpdfsdk/include/fsdk_basean...
File fpdfsdk/include/fsdk_baseannot.h (right):

https://codereview.chromium.org/1473503002/diff/1/fpdfsdk/include/fsdk_basean...
fpdfsdk/include/fsdk_baseannot.h:18: #include "fx_systemhandler.h"
On 2015/11/24 00:45:14, Lei Zhang wrote:
> this comes last, might as well make it fpdfsdk/include/fx_systemhandler.h

Done.

https://codereview.chromium.org/1473503002/diff/1/fpdfsdk/include/fsdk_mgr.h
File fpdfsdk/include/fsdk_mgr.h (right):

https://codereview.chromium.org/1473503002/diff/1/fpdfsdk/include/fsdk_mgr.h#...
fpdfsdk/include/fsdk_mgr.h:488: CPDFXFA_Document* GetXFADocument() const {
return m_pDoc; }
On 2015/11/24 00:45:14, Lei Zhang wrote:
> Should we even bother with this? Can we just use GetUnderlyingDocument() even
in
> XFA-only code? I'm not leaning one way or the other, just wondering.
I'd prefer to be unambiguous where possible, if we know it's inside an XFA-only
block, I'd rather just say so. The UnderlyingType should only appear where it
could be one or the other, I think.

https://codereview.chromium.org/1473503002/diff/1/fpdfsdk/src/fsdk_annothandl...
File fpdfsdk/src/fsdk_annothandler.cpp (right):

https://codereview.chromium.org/1473503002/diff/1/fpdfsdk/src/fsdk_annothandl...
fpdfsdk/src/fsdk_annothandler.cpp:641: if (sSubType == BFFT_SIGNATURE) {
On 2015/11/24 00:45:14, Lei Zhang wrote:
> BTW, this file is filllllllled with these.

Acknowledged.

[Lei Zhang, 2015-11-24 01:02:30]

lgtm

[Tom Sepez, 2015-11-24 17:50:15]

Added a few more uses (now TBR)

[Tom Sepez, 2015-11-24 17:50:58]

Committed patchset #3 (id:40001) manually as
50d12ada784ad3ba3f9ed6935d59f1ce828695e5 (presubmit successful).

[Lei Zhang, 2015-11-24 18:13:09]

https://codereview.chromium.org/1473503002/diff/40001/fpdfsdk/src/fsdk_basefo...
File fpdfsdk/src/fsdk_baseform.cpp (right):

https://codereview.chromium.org/1473503002/diff/40001/fpdfsdk/src/fsdk_basefo...
fpdfsdk/src/fsdk_baseform.cpp:2267: CPDF_Document* pDocument =
m_pDocument->GetDocument()->GetPDFDoc();
Looks like you got more to change.