fpdfsdk/src/javascript/JS_Runtime.cpp - Issue 1473503002: Introduce "underlying types" to abstract XFA differences.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/JS_Runtime.cpp

Issue 1473503002: Introduce "underlying types" to abstract XFA differences. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: rebase past Jun's CL. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/javascript/JS_Runtime.cpp

diff --git a/fpdfsdk/src/javascript/JS_Runtime.cpp b/fpdfsdk/src/javascript/JS_Runtime.cpp

index ac6e99d1cd632a52f5bcd9b5a5acf03c2b34d185..b195b429571a7336401bcb826cc467ae6c370ff7 100644

--- a/fpdfsdk/src/javascript/JS_Runtime.cpp

+++ b/fpdfsdk/src/javascript/JS_Runtime.cpp

@@ -93,7 +93,7 @@ CJS_Runtime::~CJS_Runtime() {

for (auto* obs : m_observers)

obs->OnDestroyed();

- for (int i = 0; i < m_ContextArray.GetSize(); i++)

+ for (int i = 0, sz = m_ContextArray.GetSize(); i < sz; i++)

delete m_ContextArray.GetAt(i);

m_ContextArray.RemoveAll();