fpdfsdk/src/fsdk_actionhandler.cpp - Issue 1473503002: Introduce "underlying types" to abstract XFA differences.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fsdk_actionhandler.cpp

Issue 1473503002: Introduce "underlying types" to abstract XFA differences. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: rebase past Jun's CL. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fsdk_actionhandler.cpp

diff --git a/fpdfsdk/src/fsdk_actionhandler.cpp b/fpdfsdk/src/fsdk_actionhandler.cpp

index 451381b289854de288525cad600bf08fa5ec0dfa..0a8a066885249fdded350b5966d067f7d868c110 100644

--- a/fpdfsdk/src/fsdk_actionhandler.cpp

+++ b/fpdfsdk/src/fsdk_actionhandler.cpp

@@ -434,7 +434,7 @@ void CPDFSDK_ActionHandler::DoAction_GoTo(CPDFSDK_Document* pDocument,

const CPDF_Action& action) {

ASSERT(action);

- CPDF_Document* pPDFDocument = pDocument->GetDocument()->GetPDFDoc();

+ CPDF_Document* pPDFDocument = pDocument->GetPDFDocument();

ASSERT(pPDFDocument);

CPDF_Dest MyDest = action.GetDest(pPDFDocument);

@@ -470,7 +470,7 @@ void CPDFSDK_ActionHandler::DoAction_URI(CPDFSDK_Document* pDocument,

CPDFDoc_Environment* pApp = pDocument->GetEnv();

ASSERT(pApp != NULL);

- CFX_ByteString sURI = action.GetURI(pDocument->GetDocument()->GetPDFDoc());

+ CFX_ByteString sURI = action.GetURI(pDocument->GetPDFDocument());

pApp->FFI_DoURIAction(sURI.c_str());

}