Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1473243006: Reland shipping of --harmony-destructuring-bind (Closed)

Created:
5 years ago by adamk
Modified:
5 years ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland shipping of --harmony-destructuring-bind Also fix CheckConflictingVarDeclarations() to properly handle legacy const bindings. Without that change enabling the flag causes code like: function f() { const x; var x; } to throw an early error, rather than wait to throw the error until f is invoked. The previous patch ran into problems with the fuzzer; that crash was fixed (with test coverage added) in https://crrev.com/ceb92ebfdfb561d71038793c02b42aa973f55ec4 BUG=v8:811 LOG=y TBR=rossberg@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/481bad1ff03244396ffd2731863aaa46948f438f Cr-Commit-Position: refs/heads/master@{#32306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download
M src/scopes.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M test/mozilla/mozilla.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
adamk
This patch is identical to the previously LGTM'd one at https://codereview.chromium.org/1451843002, so TBRing to rossberg
5 years ago (2015-11-25 19:50:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473243006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473243006/1
5 years ago (2015-11-25 19:51:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 20:53:29 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-25 20:54:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/481bad1ff03244396ffd2731863aaa46948f438f
Cr-Commit-Position: refs/heads/master@{#32306}

Powered by Google App Engine
This is Rietveld 408576698