Move --harmony-destructuring-bind to shipping

Move --harmony-destructuring-bind to shipping

Also fix CheckConflictingVarDeclarations() to properly handle
legacy const bindings. Without that change enabling the flag
causes code like:

  function f() { const x; var x; }

to throw an early error, rather than wait to throw the error
until f is invoked.

BUG=v8:811
LOG=y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Committed: https://crrev.com/515093630a4a925a66d550561e38293d49633f10
Cr-Commit-Position: refs/heads/master@{#32222}

[adamk, 2015-11-16 19:23:26]

Description was changed from

==========
Move --harmony-destructuring-bind to shipping

Also rename it from "--harmony-destructuring" to distinguish it from
destructuring assignment, which is still a work in progress.

BUG=v8:811
LOG=y
==========

to

==========
Move --harmony-destructuring-bind to shipping

Also rename it from "--harmony-destructuring" to distinguish it from
destructuring assignment, which is still a work in progress.

BUG=v8:811
LOG=y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

[adamk, 2015-11-16 19:24:12]

adamk@chromium.org changed reviewers:
+ rossberg@chromium.org

[adamk, 2015-11-16 20:09:03]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-16 20:09:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1451843002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1451843002/20001

[commit-bot: I haz the power, 2015-11-16 20:23:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-16 20:23:15]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

[adamk, 2015-11-16 21:08:57]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-16 21:09:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1451843002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1451843002/40001

[commit-bot: I haz the power, 2015-11-16 21:21:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-16 21:21:52]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/11888)

[adamk, 2015-11-16 23:26:47]

So the issue here is that CheckConflictingVarDeclarations() does not play nicely
with legacy const, and fixing it up to do so would add a bit of complexity. Will
see what the right way to do that is. Meanwhile, I'm working on just the rename
as a separate patch.

[adamk, 2015-11-23 21:05:14]

Description was changed from

==========
Move --harmony-destructuring-bind to shipping

Also rename it from "--harmony-destructuring" to distinguish it from
destructuring assignment, which is still a work in progress.

BUG=v8:811
LOG=y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

to

==========
Move --harmony-destructuring-bind to shipping

Also fix CheckConflictingVarDeclarations() to properly handle
legacy const bindings. Without that change enabling the flag
causes code like:

  function f() { const x; var x; }

to throw an early error, rather than wait to throw the error
until f is invoked.

BUG=v8:811
LOG=y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

[adamk, 2015-11-23 22:20:27]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-23 22:20:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1451843002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1451843002/80001

[adamk, 2015-11-23 22:58:58]

Okay, this is ready for review

[commit-bot: I haz the power, 2015-11-23 23:57:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 23:57:53]

Dry run: This issue passed the CQ dry run.

[rossberg, 2015-11-24 07:56:16]

lgtm

[adamk, 2015-11-24 16:48:28]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2015-11-24 16:48:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1451843002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1451843002/80001

[commit-bot: I haz the power, 2015-11-24 16:49:50]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-24 16:50:21]

Patchset 5 (id:??) landed as
https://crrev.com/515093630a4a925a66d550561e38293d49633f10
Cr-Commit-Position: refs/heads/master@{#32222}

[adamk, 2015-11-24 18:58:36]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1470333002/ by adamk@chromium.org.

The reason for reverting is: Fails on V8 Fuzzer:
https://build.chromium.org/p/client.v8/builders/V8%20Fuzzer/builds/6028
.

[adamk, 2015-11-24 20:22:39]

On 2015/11/24 18:58:36, adamk wrote:
> A revert of this CL (patchset #5 id:80001) has been created in
> https://codereview.chromium.org/1470333002/ by mailto:adamk@chromium.org.
> 
> The reason for reverting is: Fails on V8 Fuzzer:
> https://build.chromium.org/p/client.v8/builders/V8%20Fuzzer/builds/6028
> .

Cause identified, fix is up for review at
https://codereview.chromium.org/1471973003/