Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1473223002: Update gclient solution advisory for WebRTC tests. (Closed)

Created:
5 years ago by phoglund_chromium
Modified:
5 years ago
Reviewers:
ajose
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, tnakamura+watch_chromium.org, phoglund+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update gclient solution advisory for WebRTC tests. We need to run download_from_google_storage --config nowaways before adding webrtc.DEPS to .gclient, so update the help text to that effect. R=ajose@chromium.org BUG=532554, 525849 Committed: https://crrev.com/4b8b7b4bf25ab6f8c999382021d7efe5049c48bf Cr-Commit-Position: refs/heads/master@{#361618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc View 6 chunks +6 lines, -14 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_common.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_common.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
phoglund_chromium
5 years ago (2015-11-24 12:38:25 UTC) #1
ajose
On 2015/11/24 12:38:25, phoglund_chrome wrote: lgtm. Thanks!
5 years ago (2015-11-24 17:39:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473223002/1
5 years ago (2015-11-25 09:44:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 10:33:37 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-25 10:35:05 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4b8b7b4bf25ab6f8c999382021d7efe5049c48bf
Cr-Commit-Position: refs/heads/master@{#361618}

Powered by Google App Engine
This is Rietveld 408576698