Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2323)

Unified Diff: chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc

Issue 1473223002: Update gclient solution advisory for WebRTC tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/media/webrtc_browsertest_common.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
diff --git a/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc b/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
index 8e77e216518af09a906a36e9bb60aa8633eb4c7d..bda1cd2b60f0cbdc4db9c99aafb18499a99996a1 100644
--- a/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
+++ b/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
@@ -25,15 +25,6 @@
#include "net/test/python_utils.h"
#include "ui/gl/gl_switches.h"
-// You need this solution to run this test. The solution will download appengine
-// and the apprtc code for you.
-const char kAdviseOnGclientSolution[] =
- "You need to add this solution to your .gclient to run this test:\n"
- "{\n"
- " \"name\" : \"webrtc.DEPS\",\n"
- " \"url\" : \"https://chromium.googlesource.com/chromium/deps/"
- "webrtc/webrtc.DEPS\",\n"
- "}";
const char kTitlePageOfAppEngineAdminPage[] = "Instances";
const char kIsApprtcCallUpJavascript[] =
@@ -85,7 +76,8 @@ class WebRtcApprtcBrowserTest : public WebRtcTestBase {
FILE_PATH_LITERAL("../google_appengine/dev_appserver.py"));
if (!base::PathExists(appengine_dev_appserver)) {
LOG(ERROR) << "Missing appengine sdk at " <<
- appengine_dev_appserver.value() << ". " << kAdviseOnGclientSolution;
+ appengine_dev_appserver.value() << ".\n" <<
+ test::kAdviseOnGclientSolution;
return false;
}
@@ -93,7 +85,7 @@ class WebRtcApprtcBrowserTest : public WebRtcTestBase {
GetSourceDir().Append(FILE_PATH_LITERAL("out/apprtc/out/app_engine"));
if (!base::PathExists(apprtc_dir)) {
LOG(ERROR) << "Missing AppRTC AppEngine app at " <<
- apprtc_dir.value() << ". " << kAdviseOnGclientSolution;
+ apprtc_dir.value() << ".\n" << test::kAdviseOnGclientSolution;
return false;
}
if (!base::PathExists(apprtc_dir.Append(FILE_PATH_LITERAL("app.yaml")))) {
@@ -132,7 +124,7 @@ class WebRtcApprtcBrowserTest : public WebRtcTestBase {
#endif
if (!base::PathExists(collider_server)) {
LOG(ERROR) << "Missing Collider server binary at " <<
- collider_server.value() << ". " << kAdviseOnGclientSolution;
+ collider_server.value() << ".\n" << test::kAdviseOnGclientSolution;
return false;
}
@@ -209,7 +201,7 @@ class WebRtcApprtcBrowserTest : public WebRtcTestBase {
FILE_PATH_LITERAL("../firefox-nightly/firefox/firefox"));
if (!base::PathExists(firefox_binary)) {
LOG(ERROR) << "Missing firefox binary at " <<
- firefox_binary.value() << ". " << kAdviseOnGclientSolution;
+ firefox_binary.value() << ".\n" << test::kAdviseOnGclientSolution;
return false;
}
base::FilePath firefox_launcher =
@@ -217,7 +209,7 @@ class WebRtcApprtcBrowserTest : public WebRtcTestBase {
FILE_PATH_LITERAL("../webrtc.DEPS/run_firefox_webrtc.py"));
if (!base::PathExists(firefox_launcher)) {
LOG(ERROR) << "Missing firefox launcher at " <<
- firefox_launcher.value() << ". " << kAdviseOnGclientSolution;
+ firefox_launcher.value() << ".\n" << test::kAdviseOnGclientSolution;
return false;
}
« no previous file with comments | « no previous file | chrome/browser/media/webrtc_browsertest_common.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698