Update gclient solution advisory for WebRTC tests.

chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/files/file_enumerator.h"
 #include "base/path_service.h"
 #include "base/process/launch.h"
 #include "base/rand_util.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/infobars/infobar_responder.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/media/webrtc_browsertest_base.h"
 #include "chrome/browser/media/webrtc_browsertest_common.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/website_settings/permission_bubble_manager.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/test/browser_test_utils.h"
 #include "media/base/media_switches.h"
 #include "net/test/python_utils.h"
 #include "ui/gl/gl_switches.h"
 
-// You need this solution to run this test. The solution will download appengine
-// and the apprtc code for you.
-const char kAdviseOnGclientSolution[] =
-    "You need to add this solution to your .gclient to run this test:\n"
-    "{\n"
-    "  \"name\"        : \"webrtc.DEPS\",\n"
-    "  \"url\"         : \"https://chromium.googlesource.com/chromium/deps/"
-    "webrtc/webrtc.DEPS\",\n"
-    "}";
 const char kTitlePageOfAppEngineAdminPage[] = "Instances";
 
 const char kIsApprtcCallUpJavascript[] =
     "var remoteVideo = document.querySelector('#remote-video');"
     "var remoteVideoActive ="
     "    remoteVideo != null &&"
     "    remoteVideo.classList.contains('active');"
     "window.domAutomationController.send(remoteVideoActive.toString());";
 
 
@@ skipping 31 matching lines @@
     LOG(INFO) << "Exiting TearDown";
   }
 
  protected:
   bool LaunchApprtcInstanceOnLocalhost(const std::string& port) {
     base::FilePath appengine_dev_appserver =
         GetSourceDir().Append(
             FILE_PATH_LITERAL("../google_appengine/dev_appserver.py"));
     if (!base::PathExists(appengine_dev_appserver)) {
       LOG(ERROR) << "Missing appengine sdk at " <<
-          appengine_dev_appserver.value() << ". " << kAdviseOnGclientSolution;
+          appengine_dev_appserver.value() << ".\n" <<
+          test::kAdviseOnGclientSolution;
       return false;
     }
 
     base::FilePath apprtc_dir =
         GetSourceDir().Append(FILE_PATH_LITERAL("out/apprtc/out/app_engine"));
     if (!base::PathExists(apprtc_dir)) {
       LOG(ERROR) << "Missing AppRTC AppEngine app at " <<
-          apprtc_dir.value() << ". " << kAdviseOnGclientSolution;
+          apprtc_dir.value() << ".\n" << test::kAdviseOnGclientSolution;
       return false;
     }
     if (!base::PathExists(apprtc_dir.Append(FILE_PATH_LITERAL("app.yaml")))) {
       LOG(ERROR) << "The AppRTC AppEngine app at " <<
           apprtc_dir.value() << " appears to have not been built." <<
           "This should have been done by webrtc.DEPS scripts which invoke " <<
           "'grunt build' on AppRTC.";
       return false;
     }
 
@@ skipping 18 matching lines @@
     // runhooks stage when webrtc.DEPS/build_apprtc_collider.py runs.
 #if defined(OS_WIN)
     base::FilePath collider_server = GetSourceDir().Append(
         FILE_PATH_LITERAL("out/go-workspace/bin/collidermain.exe"));
 #else
     base::FilePath collider_server = GetSourceDir().Append(
         FILE_PATH_LITERAL("out/go-workspace/bin/collidermain"));
 #endif
     if (!base::PathExists(collider_server)) {
       LOG(ERROR) << "Missing Collider server binary at " <<
-          collider_server.value() << ". " << kAdviseOnGclientSolution;
+          collider_server.value() << ".\n" << test::kAdviseOnGclientSolution;
       return false;
     }
 
     base::CommandLine command_line(collider_server);
 
     command_line.AppendArg("-tls=false");
     command_line.AppendArg("-port=" + collider_port);
     command_line.AppendArg("-room-server=" + apprtc_url);
 
     DVLOG(1) << "Running " << command_line.GetCommandLineString();
@@ skipping 56 matching lines @@
     PathService::Get(base::DIR_SOURCE_ROOT, &source_dir);
     return source_dir;
   }
 
   bool LaunchFirefoxWithUrl(const GURL& url) {
     base::FilePath firefox_binary =
         GetSourceDir().Append(
             FILE_PATH_LITERAL("../firefox-nightly/firefox/firefox"));
     if (!base::PathExists(firefox_binary)) {
       LOG(ERROR) << "Missing firefox binary at " <<
-          firefox_binary.value() << ". " << kAdviseOnGclientSolution;
+          firefox_binary.value() << ".\n" << test::kAdviseOnGclientSolution;
       return false;
     }
     base::FilePath firefox_launcher =
         GetSourceDir().Append(
             FILE_PATH_LITERAL("../webrtc.DEPS/run_firefox_webrtc.py"));
     if (!base::PathExists(firefox_launcher)) {
       LOG(ERROR) << "Missing firefox launcher at " <<
-          firefox_launcher.value() << ". " << kAdviseOnGclientSolution;
+          firefox_launcher.value() << ".\n" << test::kAdviseOnGclientSolution;
       return false;
     }
 
     base::CommandLine command_line(firefox_launcher);
     command_line.AppendSwitchPath("--binary", firefox_binary);
     command_line.AppendSwitchASCII("--webpage", url.spec());
 
     DVLOG(1) << "Running " << command_line.GetCommandLineString();
     firefox_ = base::LaunchProcess(command_line, base::LaunchOptions());
     return firefox_.IsValid();
@@ skipping 81 matching lines @@
       InfoBarService::FromWebContents(chrome_tab), InfoBarResponder::ACCEPT);
   ui_test_utils::NavigateToURL(browser(), room_url);
 
   ASSERT_TRUE(LaunchFirefoxWithUrl(room_url));
 
   ASSERT_TRUE(WaitForCallToComeUp(chrome_tab));
 
   // Ensure Firefox manages to send video our way.
   ASSERT_TRUE(DetectRemoteVideoPlaying(chrome_tab));
 }