Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: breakpad/BUILD.gn

Issue 1473203002: [Linux] Turn off -mstackrealign for breakpad in ia32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added bug reference in comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | breakpad/breakpad.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//testing/test.gni") 5 import("//testing/test.gni")
6 6
7 if (is_android) { 7 if (is_android) {
8 import("//build/config/android/rules.gni") 8 import("//build/config/android/rules.gni")
9 } 9 }
10 10
(...skipping 527 matching lines...) Expand 10 before | Expand all | Expand 10 after
538 configs -= [ "//build/config/compiler:chromium_code" ] 538 configs -= [ "//build/config/compiler:chromium_code" ]
539 configs += [ "//build/config/compiler:no_chromium_code" ] 539 configs += [ "//build/config/compiler:no_chromium_code" ]
540 public_configs = [ ":client_config" ] 540 public_configs = [ ":client_config" ]
541 541
542 if (current_cpu == "arm" && is_chromeos) { 542 if (current_cpu == "arm" && is_chromeos) {
543 # Avoid running out of registers in 543 # Avoid running out of registers in
544 # linux_syscall_support.h:sys_clone()'s inline assembly. 544 # linux_syscall_support.h:sys_clone()'s inline assembly.
545 cflags = [ "-marm" ] 545 cflags = [ "-marm" ]
546 } 546 }
547 547
548 if (current_cpu == "x86" && is_clang) {
549 # Clang's -mstackrealign doesn't work well with
550 # linux_syscall_support.h hand written asm syscalls.
551 # See https://crbug.com/556393
552 cflags -= [ "-mstackrealign" ]
553 }
554
548 if (is_android) { 555 if (is_android) {
549 sources += [ "src/common/android/breakpad_getcontext.S" ] 556 sources += [ "src/common/android/breakpad_getcontext.S" ]
550 } 557 }
551 558
552 libs = [ "dl" ] 559 libs = [ "dl" ]
553 560
554 include_dirs = [ 561 include_dirs = [
555 ".", 562 ".",
556 "src", 563 "src",
557 "src/client", 564 "src/client",
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
643 if (is_clang) { 650 if (is_clang) {
644 # See http://crbug.com/138571#c18 651 # See http://crbug.com/138571#c18
645 cflags = [ "-Wno-unused-value" ] 652 cflags = [ "-Wno-unused-value" ]
646 } 653 }
647 654
648 if (is_android) { 655 if (is_android) {
649 sources += [ "src/common/android/breakpad_getcontext_unittest.cc" ] 656 sources += [ "src/common/android/breakpad_getcontext_unittest.cc" ]
650 libs = [ "log" ] 657 libs = [ "log" ]
651 include_dirs += [ "src/common/android/include" ] 658 include_dirs += [ "src/common/android/include" ]
652 } 659 }
660
661 if (current_cpu == "x86" && is_clang) {
662 # Clang's -mstackrealign doesn't work well with
663 # linux_syscall_support.h hand written asm syscalls.
664 # See https://crbug.com/556393
665 cflags -= [ "-mstackrealign" ]
666 }
653 } 667 }
654 668
655 executable("linux_dumper_unittest_helper") { 669 executable("linux_dumper_unittest_helper") {
656 set_sources_assignment_filter([]) 670 set_sources_assignment_filter([])
657 testonly = true 671 testonly = true
658 sources = [ 672 sources = [
659 "src/client/linux/minidump_writer/linux_dumper_unittest_helper.cc", 673 "src/client/linux/minidump_writer/linux_dumper_unittest_helper.cc",
660 ] 674 ]
661 deps = [ 675 deps = [
662 ":processor_support", 676 ":processor_support",
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
845 } 859 }
846 } 860 }
847 861
848 test_runner_script("breakpad_unittests__test_runner_script") { 862 test_runner_script("breakpad_unittests__test_runner_script") {
849 test_name = "breakpad_unittests" 863 test_name = "breakpad_unittests"
850 test_type = "gtest" 864 test_type = "gtest"
851 test_suite = "breakpad_unittests" 865 test_suite = "breakpad_unittests"
852 isolate_file = "breakpad_unittests.isolate" 866 isolate_file = "breakpad_unittests.isolate"
853 } 867 }
854 } 868 }
OLDNEW
« no previous file with comments | « no previous file | breakpad/breakpad.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698