chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc - Issue 1473153002: PageLoadMetricsObservers observe individual page loads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc

Issue 1473153002: PageLoadMetricsObservers observe individual page loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: destroy order Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h ('k') | chrome/browser/page_load_metrics/page_load_metrics_initialize.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc

index cfa4fbb00bcdf5a02616d717ff398ae35525741e..58df2d123978ae925e7a32dd63b33348bd841b10 100644

--- a/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc

@@ -11,9 +11,8 @@

namespace chrome {

-StaleWhileRevalidateMetricsObserver::StaleWhileRevalidateMetricsObserver(

- page_load_metrics::PageLoadMetricsObservable* metrics)

- : is_interesting_domain_(false), metrics_(metrics) {}

+StaleWhileRevalidateMetricsObserver::StaleWhileRevalidateMetricsObserver()

+ : is_interesting_domain_(false) {}

void StaleWhileRevalidateMetricsObserver::OnCommit(

content::NavigationHandle* navigation_handle) {

@@ -47,9 +46,4 @@ void StaleWhileRevalidateMetricsObserver::OnComplete(

}

-void StaleWhileRevalidateMetricsObserver::OnPageLoadMetricsGoingAway() {

- metrics_->RemoveObserver(this);

- delete this;

} // namespace chrome