Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc

Issue 1473153002: PageLoadMetricsObservers observe individual page loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: destroy order Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/observers/stale_while_revalidate_metr ics_observer.h" 5 #include "chrome/browser/page_load_metrics/observers/stale_while_revalidate_metr ics_observer.h"
6 6
7 #include "components/page_load_metrics/browser/page_load_metrics_util.h" 7 #include "components/page_load_metrics/browser/page_load_metrics_util.h"
8 #include "components/page_load_metrics/common/page_load_timing.h" 8 #include "components/page_load_metrics/common/page_load_timing.h"
9 #include "content/public/browser/navigation_handle.h" 9 #include "content/public/browser/navigation_handle.h"
10 #include "net/base/stale_while_revalidate_experiment_domains.h" 10 #include "net/base/stale_while_revalidate_experiment_domains.h"
11 11
12 namespace chrome { 12 namespace chrome {
13 13
14 StaleWhileRevalidateMetricsObserver::StaleWhileRevalidateMetricsObserver( 14 StaleWhileRevalidateMetricsObserver::StaleWhileRevalidateMetricsObserver()
15 page_load_metrics::PageLoadMetricsObservable* metrics) 15 : is_interesting_domain_(false) {}
16 : is_interesting_domain_(false), metrics_(metrics) {}
17 16
18 void StaleWhileRevalidateMetricsObserver::OnCommit( 17 void StaleWhileRevalidateMetricsObserver::OnCommit(
19 content::NavigationHandle* navigation_handle) { 18 content::NavigationHandle* navigation_handle) {
20 is_interesting_domain_ = net::IsHostInStaleWhileRevalidateExperimentDomain( 19 is_interesting_domain_ = net::IsHostInStaleWhileRevalidateExperimentDomain(
21 navigation_handle->GetURL().host()); 20 navigation_handle->GetURL().host());
22 } 21 }
23 22
24 void StaleWhileRevalidateMetricsObserver::OnComplete( 23 void StaleWhileRevalidateMetricsObserver::OnComplete(
25 const page_load_metrics::PageLoadTiming& timing, 24 const page_load_metrics::PageLoadTiming& timing,
26 const page_load_metrics::PageLoadExtraInfo& extra_info) { 25 const page_load_metrics::PageLoadExtraInfo& extra_info) {
(...skipping 13 matching lines...) Expand all
40 timing.first_layout); 39 timing.first_layout);
41 } 40 }
42 if (!timing.first_text_paint.is_zero()) { 41 if (!timing.first_text_paint.is_zero()) {
43 PAGE_LOAD_HISTOGRAM( 42 PAGE_LOAD_HISTOGRAM(
44 "PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2." 43 "PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2."
45 "NavigationToFirstTextPaint", 44 "NavigationToFirstTextPaint",
46 timing.first_text_paint); 45 timing.first_text_paint);
47 } 46 }
48 } 47 }
49 48
50 void StaleWhileRevalidateMetricsObserver::OnPageLoadMetricsGoingAway() {
51 metrics_->RemoveObserver(this);
52 delete this;
53 }
54
55 } // namespace chrome 49 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698