chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h - Issue 1473153002: PageLoadMetricsObservers observe individual page loads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h

Issue 1473153002: PageLoadMetricsObservers observe individual page loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: destroy order Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/page_load_metrics_observers_unittest.cc ('k') | chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h b/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h

index d60aeb9bee6d17d769f04661d2677c1bc8493d5b..19fb1882c71071a92f8e3626f1c267809693f9f3 100644

--- a/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h

@@ -13,20 +13,17 @@ namespace chrome {

class StaleWhileRevalidateMetricsObserver

: public page_load_metrics::PageLoadMetricsObserver {

public:

- explicit StaleWhileRevalidateMetricsObserver(

- page_load_metrics::PageLoadMetricsObservable* metrics);

+ StaleWhileRevalidateMetricsObserver();

// page_load_metrics::PageLoadMetricsObserver implementation:

void OnCommit(content::NavigationHandle* navigation_handle) override;

void OnComplete(

const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& extra_info) override;

- void OnPageLoadMetricsGoingAway() override;

private:

// True if the committed URL is one of the domains of interest to the

// stale-while-revalidate experiment.

bool is_interesting_domain_;

- page_load_metrics::PageLoadMetricsObservable* const metrics_;

DISALLOW_COPY_AND_ASSIGN(StaleWhileRevalidateMetricsObserver);

};