Build fixes for Clang on Windows

Build fixes for Clang on Windows

See e.g. http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/4502/steps/compile/logs/stdio

BUG=chromium:82385
R=mark@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/33414779e1c16704897a06ecb335aa9f9a2b46d7

[hans, 2015-11-26 01:51:56]

hans@chromium.org changed reviewers:
+ scottmg@chromium.org

[hans, 2015-11-26 01:51:57]

Please take a look.

[Mark Mentovai, 2015-11-26 02:06:36]

mark@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2015-11-26 02:06:37]

LGTM

https://codereview.chromium.org/1473073008/diff/1/snapshot/win/pe_image_reade...
File snapshot/win/pe_image_reader.cc (right):

https://codereview.chromium.org/1473073008/diff/1/snapshot/win/pe_image_reade...
snapshot/win/pe_image_reader.cc:91: return false;
{} this now

[hans, 2015-11-26 03:16:53]

https://codereview.chromium.org/1473073008/diff/1/snapshot/win/pe_image_reade...
File snapshot/win/pe_image_reader.cc (right):

https://codereview.chromium.org/1473073008/diff/1/snapshot/win/pe_image_reade...
snapshot/win/pe_image_reader.cc:91: return false;
On 2015/11/26 02:06:37, Mark Mentovai wrote:
> {} this now

Done.

[hans, 2015-11-26 03:18:52]

I tried to "git cl land" this, but it didn't work:
error: failed to push some refs to
'https://chromium.googlesource.com/crashpad/crashpad.git'
Failed to push. If this persists, please file a bug.

Can someone help me commit this or give me commit access if that's what's
required?

[Mark Mentovai, 2015-11-26 04:47:42]

Description was changed from

==========
Build fixes for Clang on Windows

See e.g.
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/4502/step...

BUG=82385
==========

to

==========
Build fixes for Clang on Windows

See e.g.
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/4502/step...

BUG=chromium:82385
==========

[Mark Mentovai, 2015-11-26 04:50:35]

Description was changed from

==========
Build fixes for Clang on Windows

See e.g.
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/4502/step...

BUG=chromium:82385
==========

to

==========
Build fixes for Clang on Windows

See e.g.
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/4502/step...

BUG=chromium:82385
R=mark@chromium.org

Committed:
https://chromium.googlesource.com/crashpad/crashpad/+/33414779e1c16704897a06e...
==========

[Mark Mentovai, 2015-11-26 04:50:36]

Committed patchset #2 (id:20001) manually as
33414779e1c16704897a06ecb335aa9f9a2b46d7 (presubmit successful).

[Mark Mentovai, 2015-11-26 04:50:50]

No CQ here yet. I landed it for you.