snapshot/win/pe_image_reader.cc - Issue 1473073008: Build fixes for Clang on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/win/pe_image_reader.cc

Issue 1473073008: Build fixes for Clang on Windows (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad.git@master

Patch Set: curlies Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: snapshot/win/pe_image_reader.cc

diff --git a/snapshot/win/pe_image_reader.cc b/snapshot/win/pe_image_reader.cc

index 82bce0645ad57f82fcf6dc6f69b073660b20f9c1..f408fb18c77de9a5ca15269b6873182d62e6770e 100644

--- a/snapshot/win/pe_image_reader.cc

+++ b/snapshot/win/pe_image_reader.cc

@@ -86,8 +86,10 @@ bool PEImageReader::GetCrashpadInfo(

INITIALIZATION_STATE_DCHECK_VALID(initialized_);

IMAGE_SECTION_HEADER section;

- if (!GetSectionByName<NtHeadersForTraits<Traits>::type>("CPADinfo", &section))

+ if (!GetSectionByName<typename NtHeadersForTraits<Traits>::type>("CPADinfo",

+ &section)) {

return false;

+ }

if (section.Misc.VirtualSize < sizeof(process_types::CrashpadInfo<Traits>)) {

LOG(WARNING) << "small crashpad info section size "

« no previous file with comments | « no previous file | snapshot/win/process_snapshot_win.cc » ('j') | no next file with comments »