Build fixes for Clang on Windows

snapshot/win/pe_image_reader.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 68 matching lines @@
   INITIALIZATION_STATE_SET_VALID(initialized_);
   return true;
 }
 
 template <class Traits>
 bool PEImageReader::GetCrashpadInfo(
     process_types::CrashpadInfo<Traits>* crashpad_info) const {
   INITIALIZATION_STATE_DCHECK_VALID(initialized_);
 
   IMAGE_SECTION_HEADER section;
-  if (!GetSectionByName<NtHeadersForTraits<Traits>::type>("CPADinfo", &section))
+  if (!GetSectionByName<typename NtHeadersForTraits<Traits>::type>("CPADinfo",
+                                                                   &section))
     return false;

[Mark Mentovai, 2015/11/26 02:06:37]

{} this now

[hans, 2015/11/26 03:16:52]

Done.

 
   if (section.Misc.VirtualSize < sizeof(process_types::CrashpadInfo<Traits>)) {
     LOG(WARNING) << "small crashpad info section size "
                  << section.Misc.VirtualSize << ", " << module_name_;
     return false;
   }
 
   WinVMAddress crashpad_info_address = Address() + section.VirtualAddress;
   CheckedWinAddressRange crashpad_info_range(process_reader_->Is64Bit(),
                                              crashpad_info_address,
@@ skipping 200 matching lines @@
 // Explicit instantiations with the only 2 valid template arguments to avoid
 // putting the body of the function in the header.
 template bool PEImageReader::GetCrashpadInfo<process_types::internal::Traits32>(
     process_types::CrashpadInfo<process_types::internal::Traits32>*
         crashpad_info) const;
 template bool PEImageReader::GetCrashpadInfo<process_types::internal::Traits64>(
     process_types::CrashpadInfo<process_types::internal::Traits64>*
         crashpad_info) const;
 
 }  // namespace crashpad