Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1472833004: Revert of Add test to check PRNG quality. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add test to check PRNG quality. (patchset #5 id:80001 of https://codereview.chromium.org/1467133006/ ) Reason for revert: failure here https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosse4/builds/6842/steps/Check/logs/RandomBitCorrelations12 Original issue's description: > Add test to check PRNG quality. > > Credits go to Erik Corry. Taken from: > https://github.com/dart-lang/fletch/blob/master/src/shared/random_test.cc > > R=jkummerow@chromium.org > BUG=v8:4566 > LOG=N > > Committed: https://crrev.com/1a90af55d1e9d7d84e813dc367d475457c7df1ff > Cr-Commit-Position: refs/heads/master@{#32211} > > Committed: https://crrev.com/3d84f05cd77091ea8dde7821973f13f53dbaa730 > Cr-Commit-Position: refs/heads/master@{#32238} > > Committed: https://crrev.com/eeee7ab050013782704b5f89e49d06a30b3455c4 > Cr-Commit-Position: refs/heads/master@{#32246} TBR=jkummerow@chromium.org,erikcorry@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4566 Committed: https://crrev.com/47e1ab78d7040bea417dd6da9f722cce5168c7c8 Cr-Commit-Position: refs/heads/master@{#32247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -191 lines) Patch
M test/cctest/test-random-number-generator.cc View 1 chunk +0 lines, -122 lines 0 comments Download
D test/mjsunit/random-bit-correlations.js View 1 chunk +0 lines, -69 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of Add test to check PRNG quality.
5 years ago (2015-11-25 07:44:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472833004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472833004/1
5 years ago (2015-11-25 07:44:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 07:44:26 UTC) #3
commit-bot: I haz the power
5 years ago (2015-11-25 07:44:37 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47e1ab78d7040bea417dd6da9f722cce5168c7c8
Cr-Commit-Position: refs/heads/master@{#32247}

Powered by Google App Engine
This is Rietveld 408576698