Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1467133006:
Add test to check PRNG quality. (Closed)
DescriptionAdd test to check PRNG quality.
Credits go to Erik Corry. Taken from:
https://github.com/dart-lang/fletch/blob/master/src/shared/random_test.cc
R=jkummerow@chromium.org
BUG=v8:4566
LOG=N
Committed: https://crrev.com/1a90af55d1e9d7d84e813dc367d475457c7df1ff
Cr-Commit-Position: refs/heads/master@{#32211}
Committed: https://crrev.com/3d84f05cd77091ea8dde7821973f13f53dbaa730
Cr-Commit-Position: refs/heads/master@{#32238}
Committed: https://crrev.com/eeee7ab050013782704b5f89e49d06a30b3455c4
Cr-Commit-Position: refs/heads/master@{#32246}
Committed: https://crrev.com/713c3df41c152fb79fb53e8ed2bec476a620a79d
Cr-Commit-Position: refs/heads/master@{#32254}
Patch Set 1 #Patch Set 2 : add license #
Total comments: 2
Patch Set 3 : laywertext be gone. #Patch Set 4 : do not call into js #Patch Set 5 : split up tests. Add js test. #
Total comments: 1
Patch Set 6 : correctly set up random seed #
Messages
Total messages: 43 (18 generated)
lgtm
The CQ bit was checked by yangguo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467133006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467133006/20001
erikcorry@google.com changed reviewers: + erikcorry@google.com
https://codereview.chromium.org/1467133006/diff/20001/test/cctest/test-random... File test/cctest/test-random-number-generator.cc (right): https://codereview.chromium.org/1467133006/diff/20001/test/cctest/test-random... test/cctest/test-random-number-generator.cc:85: // POSSIBILITY OF SUCH DAMAGE. You don't need this. It's written by me for Google, so it belongs to Google.
The CQ bit was unchecked by yangguo@chromium.org
https://codereview.chromium.org/1467133006/diff/20001/test/cctest/test-random... File test/cctest/test-random-number-generator.cc (right): https://codereview.chromium.org/1467133006/diff/20001/test/cctest/test-random... test/cctest/test-random-number-generator.cc:85: // POSSIBILITY OF SUCH DAMAGE. On 2015/11/24 13:45:14, erikcorry wrote: > You don't need this. It's written by me for Google, so it belongs to Google. And... removed.
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jkummerow@chromium.org Link to the patchset: https://codereview.chromium.org/1467133006/#ps40001 (title: "laywertext be gone.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467133006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467133006/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1a90af55d1e9d7d84e813dc367d475457c7df1ff Cr-Commit-Position: refs/heads/master@{#32211}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1473613002/ by machenbach@chromium.org. The reason for reverting is: [Sheriff] Times out on arm: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20....
Message was sent while issue was closed.
Description was changed from ========== Add test to check PRNG quality. Credits go to Erik Corry. Taken from: https://github.com/dart-lang/fletch/blob/master/src/shared/random_test.cc R=jkummerow@chromium.org BUG=v8:4566 LOG=N Committed: https://crrev.com/1a90af55d1e9d7d84e813dc367d475457c7df1ff Cr-Commit-Position: refs/heads/master@{#32211} ========== to ========== Add test to check PRNG quality. Credits go to Erik Corry. Taken from: https://github.com/dart-lang/fletch/blob/master/src/shared/random_test.cc R=jkummerow@chromium.org BUG=v8:4566 LOG=N Committed: https://crrev.com/1a90af55d1e9d7d84e813dc367d475457c7df1ff Cr-Commit-Position: refs/heads/master@{#32211} ==========
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jkummerow@chromium.org Link to the patchset: https://codereview.chromium.org/1467133006/#ps60001 (title: "do not call into js")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467133006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467133006/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by yangguo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467133006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467133006/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/3d84f05cd77091ea8dde7821973f13f53dbaa730 Cr-Commit-Position: refs/heads/master@{#32238}
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1480533002/ by yangguo@chromium.org. The reason for reverting is: still timing out.
Message was sent while issue was closed.
Description was changed from ========== Add test to check PRNG quality. Credits go to Erik Corry. Taken from: https://github.com/dart-lang/fletch/blob/master/src/shared/random_test.cc R=jkummerow@chromium.org BUG=v8:4566 LOG=N Committed: https://crrev.com/1a90af55d1e9d7d84e813dc367d475457c7df1ff Cr-Commit-Position: refs/heads/master@{#32211} Committed: https://crrev.com/3d84f05cd77091ea8dde7821973f13f53dbaa730 Cr-Commit-Position: refs/heads/master@{#32238} ========== to ========== Add test to check PRNG quality. Credits go to Erik Corry. Taken from: https://github.com/dart-lang/fletch/blob/master/src/shared/random_test.cc R=jkummerow@chromium.org BUG=v8:4566 LOG=N Committed: https://crrev.com/1a90af55d1e9d7d84e813dc367d475457c7df1ff Cr-Commit-Position: refs/heads/master@{#32211} Committed: https://crrev.com/3d84f05cd77091ea8dde7821973f13f53dbaa730 Cr-Commit-Position: refs/heads/master@{#32238} ==========
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jkummerow@chromium.org Link to the patchset: https://codereview.chromium.org/1467133006/#ps80001 (title: "split up tests. Add js test.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467133006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467133006/80001
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/eeee7ab050013782704b5f89e49d06a30b3455c4 Cr-Commit-Position: refs/heads/master@{#32246}
Message was sent while issue was closed.
https://codereview.chromium.org/1467133006/diff/80001/test/mjsunit/random-bit... File test/mjsunit/random-bit-correlations.js (right): https://codereview.chromium.org/1467133006/diff/80001/test/mjsunit/random-bit... test/mjsunit/random-bit-correlations.js:13: return (Math.random() * Math.pow(2, 32)) >>> 0; This doesn't test the low bits of the floating point number. I would suggest another test that uses: Math.random() * Math.pow(2, 52)
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/1472833004/ by yangguo@chromium.org. The reason for reverting is: failure here https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosse4/build....
Message was sent while issue was closed.
Description was changed from ========== Add test to check PRNG quality. Credits go to Erik Corry. Taken from: https://github.com/dart-lang/fletch/blob/master/src/shared/random_test.cc R=jkummerow@chromium.org BUG=v8:4566 LOG=N Committed: https://crrev.com/1a90af55d1e9d7d84e813dc367d475457c7df1ff Cr-Commit-Position: refs/heads/master@{#32211} Committed: https://crrev.com/3d84f05cd77091ea8dde7821973f13f53dbaa730 Cr-Commit-Position: refs/heads/master@{#32238} Committed: https://crrev.com/eeee7ab050013782704b5f89e49d06a30b3455c4 Cr-Commit-Position: refs/heads/master@{#32246} ========== to ========== Add test to check PRNG quality. Credits go to Erik Corry. Taken from: https://github.com/dart-lang/fletch/blob/master/src/shared/random_test.cc R=jkummerow@chromium.org BUG=v8:4566 LOG=N Committed: https://crrev.com/1a90af55d1e9d7d84e813dc367d475457c7df1ff Cr-Commit-Position: refs/heads/master@{#32211} Committed: https://crrev.com/3d84f05cd77091ea8dde7821973f13f53dbaa730 Cr-Commit-Position: refs/heads/master@{#32238} Committed: https://crrev.com/eeee7ab050013782704b5f89e49d06a30b3455c4 Cr-Commit-Position: refs/heads/master@{#32246} ==========
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467133006/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467133006/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jkummerow@chromium.org Link to the patchset: https://codereview.chromium.org/1467133006/#ps100001 (title: "correctly set up random seed")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467133006/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467133006/100001
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/713c3df41c152fb79fb53e8ed2bec476a620a79d Cr-Commit-Position: refs/heads/master@{#32254} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
