Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: test/cctest/test-random-number-generator.cc

Issue 1472833004: Revert of Add test to check PRNG quality. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/random-bit-correlations.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-random-number-generator.cc
diff --git a/test/cctest/test-random-number-generator.cc b/test/cctest/test-random-number-generator.cc
index 23805f932830638cf7a121c37fd626c487764c6c..f5e05cb39636353bf8022ad9015f89ed4b003919 100644
--- a/test/cctest/test-random-number-generator.cc
+++ b/test/cctest/test-random-number-generator.cc
@@ -51,125 +51,3 @@
i->Dispose();
}
}
-
-
-// Chi squared for getting m 0s out of n bits.
-double ChiSquared(int m, int n) {
- double ys_minus_np1 = (m - n / 2.0);
- double chi_squared_1 = ys_minus_np1 * ys_minus_np1 * 2.0 / n;
- double ys_minus_np2 = ((n - m) - n / 2.0);
- double chi_squared_2 = ys_minus_np2 * ys_minus_np2 * 2.0 / n;
- return chi_squared_1 + chi_squared_2;
-}
-
-
-// Test for correlations between recent bits from the PRNG, or bits that are
-// biased.
-void RandomBitCorrelation(int random_bit) {
- FLAG_random_seed = 31415926;
- LocalContext env;
- v8::Isolate* isolate = env->GetIsolate();
- Isolate* i_isolate = reinterpret_cast<Isolate*>(isolate);
- v8::base::RandomNumberGenerator* rng = i_isolate->random_number_generator();
-#ifdef DEBUG
- const int kHistory = 2;
- const int kRepeats = 1000;
-#else
- const int kHistory = 8;
- const int kRepeats = 10000;
-#endif
- uint32_t history[kHistory];
- // The predictor bit is either constant 0 or 1, or one of the bits from the
- // history.
- for (int predictor_bit = -2; predictor_bit < 32; predictor_bit++) {
- // The predicted bit is one of the bits from the PRNG.
- for (int ago = 0; ago < kHistory; ago++) {
- // We don't want to check whether each bit predicts itself.
- if (ago == 0 && predictor_bit == random_bit) continue;
-
- // Enter the new random value into the history
- for (int i = ago; i >= 0; i--) {
- history[i] = bit_cast<uint32_t>(rng->NextInt());
- }
-
- // Find out how many of the bits are the same as the prediction bit.
- int m = 0;
- for (int i = 0; i < kRepeats; i++) {
- v8::HandleScope scope(isolate);
- uint32_t random = bit_cast<uint32_t>(rng->NextInt());
- for (int j = ago - 1; j >= 0; j--) history[j + 1] = history[j];
- history[0] = random;
-
- int predicted;
- if (predictor_bit >= 0) {
- predicted = (history[ago] >> predictor_bit) & 1;
- } else {
- predicted = predictor_bit == -2 ? 0 : 1;
- }
- int bit = (random >> random_bit) & 1;
- if (bit == predicted) m++;
- }
-
- // Chi squared analysis for k = 2 (2, states: same/not-same) and one
- // degree of freedom (k - 1).
- double chi_squared = ChiSquared(m, kRepeats);
- if (chi_squared > 24) {
- int percent = static_cast<int>(m * 100.0 / kRepeats);
- if (predictor_bit < 0) {
- PrintF("Bit %d is %d %d%% of the time\n", random_bit,
- predictor_bit == -2 ? 0 : 1, percent);
- } else {
- PrintF("Bit %d is the same as bit %d %d ago %d%% of the time\n",
- random_bit, predictor_bit, ago, percent);
- }
- }
-
- // For 1 degree of freedom this corresponds to 1 in a million. We are
- // running ~8000 tests, so that would be surprising.
- CHECK(chi_squared <= 24);
-
- // If the predictor bit is a fixed 0 or 1 then it makes no sense to
- // repeat the test with a different age.
- if (predictor_bit < 0) break;
- }
- }
-}
-
-
-#define TEST_RANDOM_BIT(BIT) \
- TEST(RandomBitCorrelations##BIT) { RandomBitCorrelation(BIT); }
-
-TEST_RANDOM_BIT(0)
-TEST_RANDOM_BIT(1)
-TEST_RANDOM_BIT(2)
-TEST_RANDOM_BIT(3)
-TEST_RANDOM_BIT(4)
-TEST_RANDOM_BIT(5)
-TEST_RANDOM_BIT(6)
-TEST_RANDOM_BIT(7)
-TEST_RANDOM_BIT(8)
-TEST_RANDOM_BIT(9)
-TEST_RANDOM_BIT(10)
-TEST_RANDOM_BIT(11)
-TEST_RANDOM_BIT(12)
-TEST_RANDOM_BIT(13)
-TEST_RANDOM_BIT(14)
-TEST_RANDOM_BIT(15)
-TEST_RANDOM_BIT(16)
-TEST_RANDOM_BIT(17)
-TEST_RANDOM_BIT(18)
-TEST_RANDOM_BIT(19)
-TEST_RANDOM_BIT(20)
-TEST_RANDOM_BIT(21)
-TEST_RANDOM_BIT(22)
-TEST_RANDOM_BIT(23)
-TEST_RANDOM_BIT(24)
-TEST_RANDOM_BIT(25)
-TEST_RANDOM_BIT(26)
-TEST_RANDOM_BIT(27)
-TEST_RANDOM_BIT(28)
-TEST_RANDOM_BIT(29)
-TEST_RANDOM_BIT(30)
-TEST_RANDOM_BIT(31)
-
-#undef TEST_RANDOM_BIT
« no previous file with comments | « no previous file | test/mjsunit/random-bit-correlations.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698