Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 147193003: [GCM] Fix memory leaks (Closed)

Created:
6 years, 11 months ago by Nicolas Zea
Modified:
6 years, 10 months ago
Reviewers:
jianli, fgorski
CC:
chromium-reviews
Visibility:
Public.

Description

[GCM] Fix memory leaks Fixes bug where we forgot to clear a ReliablePacketInfo in MCSClient. Makes GCMStore explicitly pass ownership of the outgoing message memory it allocates. BUG=337560 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247108

Patch Set 1 #

Patch Set 2 : Fix windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -156 lines) Patch
M google_apis/gcm/engine/gcm_store.h View 1 3 chunks +9 lines, -3 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.cc View 7 chunks +41 lines, -36 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl_unittest.cc View 13 chunks +55 lines, -72 lines 0 comments Download
M google_apis/gcm/engine/mcs_client.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/mcs_client.cc View 7 chunks +13 lines, -14 lines 0 comments Download
M google_apis/gcm/engine/mcs_client_unittest.cc View 1 chunk +1 line, -9 lines 0 comments Download
M google_apis/gcm/engine/user_list_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M google_apis/gcm/gcm_client_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gcm/gcm_client_impl.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nicolas Zea
PTAL
6 years, 11 months ago (2014-01-24 20:43:04 UTC) #1
Nicolas Zea
6 years, 11 months ago (2014-01-24 21:41:58 UTC) #2
jianli
lgtm Please note that win bots failed.
6 years, 11 months ago (2014-01-24 22:22:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/147193003/140001
6 years, 11 months ago (2014-01-25 00:39:45 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-25 09:23:58 UTC) #5
Message was sent while issue was closed.
Change committed as 247108

Powered by Google App Engine
This is Rietveld 408576698