google_apis/gcm/gcm_client_impl.h - Issue 147193003: [GCM] Fix memory leaks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/gcm_client_impl.h

Issue 147193003: [GCM] Fix memory leaks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix windows Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/gcm_client_impl.h

diff --git a/google_apis/gcm/gcm_client_impl.h b/google_apis/gcm/gcm_client_impl.h

index 7d1856e8ed605624454f85da1caa58627b348f59..19c1d26003179802a153b7bd33fd1867366a57c3 100644

--- a/google_apis/gcm/gcm_client_impl.h

+++ b/google_apis/gcm/gcm_client_impl.h

@@ -103,9 +103,9 @@ class GCM_EXPORT GCMClientImpl : public GCMClient {

// Runs after GCM Store load is done to trigger continuation of the

// initialization.

- void OnLoadCompleted(const GCMStore::LoadResult& result);

+ void OnLoadCompleted(scoped_ptr<GCMStore::LoadResult> result);

// Initializes mcs_client_, which handles the connection to MCS.

- void InitializeMCSClient(const GCMStore::LoadResult& result);

+ void InitializeMCSClient(scoped_ptr<GCMStore::LoadResult> result);

// Complets the first time device checkin.

void OnFirstTimeDeviceCheckinCompleted(const CheckinInfo& checkin_info);

// Starts a login on mcs_client_.

« no previous file with comments | « google_apis/gcm/engine/user_list_unittest.cc ('k') | google_apis/gcm/gcm_client_impl.cc » ('j') | no next file with comments »