Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: google_apis/gcm/engine/mcs_client_unittest.cc

Issue 147193003: [GCM] Fix memory leaks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix windows Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « google_apis/gcm/engine/mcs_client.cc ('k') | google_apis/gcm/engine/user_list_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "google_apis/gcm/engine/mcs_client.h" 5 #include "google_apis/gcm/engine/mcs_client.h"
6 6
7 #include "base/files/scoped_temp_dir.h" 7 #include "base/files/scoped_temp_dir.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 InitializeClient(); 287 InitializeClient();
288 LoginClient(std::vector<std::string>()); 288 LoginClient(std::vector<std::string>());
289 MCSMessage message(BuildDataMessage("from", "category", "X", 1, "", 0, 1, 0)); 289 MCSMessage message(BuildDataMessage("from", "category", "X", 1, "", 0, 1, 0));
290 GetFakeHandler()->ExpectOutgoingMessage(message); 290 GetFakeHandler()->ExpectOutgoingMessage(message);
291 mcs_client()->SendMessage(message); 291 mcs_client()->SendMessage(message);
292 EXPECT_TRUE(GetFakeHandler()->AllOutgoingMessagesReceived()); 292 EXPECT_TRUE(GetFakeHandler()->AllOutgoingMessagesReceived());
293 } 293 }
294 294
295 // Send a message without RMQ support while disconnected. Message send should 295 // Send a message without RMQ support while disconnected. Message send should
296 // fail immediately, invoking callback. 296 // fail immediately, invoking callback.
297 // Fails on linux_asan crbug.com/337560 297 TEST_F(MCSClientTest, SendMessageNoRMQWhileDisconnected) {
298 #if !defined(OS_POSIX)
299 #define MAYBE_SendMessageNoRMQWhileDisconnected \
300 SendMessageNoRMQWhileDisconnected
301 #else
302 #define MAYBE_SendMessageNoRMQWhileDisconnected \
303 DISABLED_SendMessageNoRMQWhileDisconnected
304 #endif
305 TEST_F(MCSClientTest, MAYBE_SendMessageNoRMQWhileDisconnected) {
306 BuildMCSClient(); 298 BuildMCSClient();
307 InitializeClient(); 299 InitializeClient();
308 300
309 EXPECT_TRUE(sent_message_id().empty()); 301 EXPECT_TRUE(sent_message_id().empty());
310 MCSMessage message(BuildDataMessage("from", "category", "X", 1, "", 0, 1, 0)); 302 MCSMessage message(BuildDataMessage("from", "category", "X", 1, "", 0, 1, 0));
311 mcs_client()->SendMessage(message); 303 mcs_client()->SendMessage(message);
312 304
313 // Message sent callback should be invoked, but no message should actually 305 // Message sent callback should be invoked, but no message should actually
314 // be sent. 306 // be sent.
315 EXPECT_EQ("X", sent_message_id()); 307 EXPECT_EQ("X", sent_message_id());
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
711 LoginClient(std::vector<std::string>()); 703 LoginClient(std::vector<std::string>());
712 PumpLoop(); 704 PumpLoop();
713 EXPECT_EQ("X", sent_message_id()); 705 EXPECT_EQ("X", sent_message_id());
714 EXPECT_EQ(MCSClient::TTL_EXCEEDED, message_send_status()); 706 EXPECT_EQ(MCSClient::TTL_EXCEEDED, message_send_status());
715 EXPECT_TRUE(GetFakeHandler()->AllOutgoingMessagesReceived()); 707 EXPECT_TRUE(GetFakeHandler()->AllOutgoingMessagesReceived());
716 } 708 }
717 709
718 } // namespace 710 } // namespace
719 711
720 } // namespace gcm 712 } // namespace gcm
OLDNEW
« no previous file with comments | « google_apis/gcm/engine/mcs_client.cc ('k') | google_apis/gcm/engine/user_list_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698