Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 147193002: Revert of Move preferred scrollbar style preference change listening from renderer to browser, 3 of 3. (Closed)

Created:
6 years, 11 months ago by Alpha Left Google
Modified:
6 years, 11 months ago
Reviewers:
Robert Sesek, jamesr, Nico
CC:
blink-reviews, jamesr, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dglazkov+blink, abarth-chromium, dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers, ccameron
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Move preferred scrollbar style preference change listening from renderer to browser, 3 of 3. (https://codereview.chromium.org/136333009/) Reason for revert: This seems to be causing a mac_rel failure and is blocking blink roll. see here: http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/215993/steps/content_browsertests/logs/stdio Original issue's description: > Move preferred scrollbar style preference change listening from renderer to browser, 3 of 3. > > This removes the preferred style listener from Blink, now that the browser > sends the value when it changes over IPC. > > BUG=306348 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165714 TBR=jamesr@chromium.org,thakis@chromium.org,rsesek@chromium.org NOTREECHECKS=true NOTRY=true BUG=306348 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -145 lines) Patch
M Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/mac/NSScrollerImpDetails.h View 3 chunks +15 lines, -6 lines 0 comments Download
A Source/platform/mac/NSScrollerImpDetails.mm View 1 chunk +95 lines, -0 lines 0 comments Download
M Source/platform/mac/ScrollAnimatorMac.mm View 26 chunks +43 lines, -43 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacCommon.h View 3 chunks +1 line, -6 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacCommon.mm View 4 chunks +2 lines, -29 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacOverlayAPI.mm View 2 chunks +2 lines, -2 lines 0 comments Download
A Source/web/mac/WebScrollbarTheme.cpp View 1 chunk +65 lines, -0 lines 0 comments Download
D Source/web/mac/WebScrollbarTheme.mm View 1 chunk +0 lines, -58 lines 0 comments Download
M Source/web/web.gypi View 1 chunk +1 line, -1 line 0 comments Download
M public/web/mac/WebScrollbarTheme.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Alpha Left Google
Created Revert of Move preferred scrollbar style preference change listening from renderer to browser, 3 ...
6 years, 11 months ago (2014-01-24 20:21:49 UTC) #1
Robert Sesek
6 years, 11 months ago (2014-01-27 15:24:23 UTC) #2
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/144363003/ by rsesek@chromium.org.

The reason for reverting is: Fixed in Chromium with
https://codereview.chromium.org/145013018.

Powered by Google App Engine
This is Rietveld 408576698