Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 145013018: Move preferred scrollbar style preference change listening from renderer to browser, 4 of 3. (Closed)

Created:
6 years, 11 months ago by Robert Sesek
Modified:
6 years, 11 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move preferred scrollbar style preference change listening from renderer to browser, 4 of 3. When --single-process, do not broker system notifications to renderers, since it will cause some content_browsertests to DCHECK. BUG=306348 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247030

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Better fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M content/browser/theme_helper_mac.mm View 1 2 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Robert Sesek
6 years, 11 months ago (2014-01-24 21:09:48 UTC) #1
Avi (use Gerrit)
I just realized that this solves the problem for the cases where the Imps listen ...
6 years, 11 months ago (2014-01-24 21:12:23 UTC) #2
Robert Sesek
On 2014/01/24 21:12:23, Avi wrote: > I just realized that this solves the problem for ...
6 years, 11 months ago (2014-01-24 21:20:49 UTC) #3
Avi (use Gerrit)
SLGTM.
6 years, 11 months ago (2014-01-24 22:17:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/145013018/60001
6 years, 11 months ago (2014-01-24 22:27:11 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-25 00:20:12 UTC) #6
Message was sent while issue was closed.
Change committed as 247030

Powered by Google App Engine
This is Rietveld 408576698