Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 136333009: Move preferred scrollbar style preference change listening from renderer to browser, 3 of 3. (Closed)

Created:
6 years, 11 months ago by Robert Sesek
Modified:
6 years, 11 months ago
Reviewers:
jamesr, Nico
CC:
blink-reviews, jamesr, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dglazkov+blink, abarth-chromium, dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers, ccameron
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move preferred scrollbar style preference change listening from renderer to browser, 3 of 3. This removes the preferred style listener from Blink, now that the browser sends the value when it changes over IPC. BUG=306348 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165714

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -233 lines) Patch
M Source/platform/blink_platform.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/mac/NSScrollerImpDetails.h View 1 2 3 chunks +6 lines, -15 lines 0 comments Download
M Source/platform/mac/NSScrollerImpDetails.mm View 1 2 1 chunk +0 lines, -95 lines 0 comments Download
M Source/platform/mac/ScrollAnimatorMac.mm View 1 2 26 chunks +33 lines, -33 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacCommon.h View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacCommon.mm View 1 2 5 chunks +29 lines, -2 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacOverlayAPI.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D Source/web/mac/WebScrollbarTheme.cpp View 1 2 1 chunk +0 lines, -65 lines 0 comments Download
A + Source/web/mac/WebScrollbarTheme.mm View 1 2 1 chunk +7 lines, -14 lines 0 comments Download
M Source/web/web.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M public/web/mac/WebScrollbarTheme.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Robert Sesek
6 years, 11 months ago (2014-01-23 18:48:50 UTC) #1
jamesr
The trybots are unhappy - has a dependency not landed or hit LKGR yet? This ...
6 years, 11 months ago (2014-01-23 20:24:26 UTC) #2
Robert Sesek
On 2014/01/23 20:24:26, jamesr wrote: > The trybots are unhappy - has a dependency not ...
6 years, 11 months ago (2014-01-23 20:28:10 UTC) #3
Nico
lgtm
6 years, 11 months ago (2014-01-23 20:33:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/136333009/50001
6 years, 11 months ago (2014-01-23 21:48:11 UTC) #5
commit-bot: I haz the power
Change committed as 165714
6 years, 11 months ago (2014-01-24 07:37:35 UTC) #6
esprehn
This patch made the tree red: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/1756
6 years, 11 months ago (2014-01-24 10:45:09 UTC) #7
Mike West
On 2014/01/24 10:45:09, esprehn wrote: > This patch made the tree red: > http://build.chromium.org/p/chromium.webkit/builders/WebKit%2520Mac10.9/builds/1756 Reverting ...
6 years, 11 months ago (2014-01-24 11:55:40 UTC) #8
Alpha Left Google
6 years, 11 months ago (2014-01-24 20:21:47 UTC) #9
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/147193002/ by hclam@chromium.org.

The reason for reverting is: This seems to be causing a mac_rel failure and is
blocking blink roll.

see here:
http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/215993...
.

Powered by Google App Engine
This is Rietveld 408576698