Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1471913004: Revert of [Interpreter] Add CreateClosure to BytecodeGraphBuilder. (Closed)

Created:
5 years ago by oth
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Interpreter] Add CreateClosure to BytecodeGraphBuilder. (patchset #8 id:140001 of https://codereview.chromium.org/1458603012/ ) Reason for revert: Build break. Original issue's description: > [Interpreter] Add CreateClosure to BytecodeGraphBuilder. > > Adds code and tests to support CreateClosure bytecode when building > graphs. > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/4cceb11b0929abcbc82bf0854554a9b66003335d > Cr-Commit-Position: refs/heads/master@{#32224} TBR=bmeurer@chromium.org,mythria@chromium.org,mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Committed: https://crrev.com/daf185b243c581cf3acdc3bc1db787a6b662d5ec Cr-Commit-Position: refs/heads/master@{#32225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -264 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +1 line, -14 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +6 lines, -17 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 30 chunks +75 lines, -50 lines 0 comments Download
M test/unittests/compiler/bytecode-graph-builder-unittest.cc View 4 chunks +2 lines, -52 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 2 chunks +0 lines, -5 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 3 chunks +0 lines, -60 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
oth
Created Revert of [Interpreter] Add CreateClosure to BytecodeGraphBuilder.
5 years ago (2015-11-24 18:10:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471913004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471913004/1
5 years ago (2015-11-24 18:10:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 18:10:49 UTC) #3
commit-bot: I haz the power
5 years ago (2015-11-24 18:11:07 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/daf185b243c581cf3acdc3bc1db787a6b662d5ec
Cr-Commit-Position: refs/heads/master@{#32225}

Powered by Google App Engine
This is Rietveld 408576698