Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: test/unittests/compiler/bytecode-graph-builder-unittest.cc

Issue 1471913004: Revert of [Interpreter] Add CreateClosure to BytecodeGraphBuilder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/interpreter/test-bytecode-generator.cc ('k') | test/unittests/compiler/node-test-utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/bytecode-graph-builder-unittest.cc
diff --git a/test/unittests/compiler/bytecode-graph-builder-unittest.cc b/test/unittests/compiler/bytecode-graph-builder-unittest.cc
index 4f2859fb392c7335c5b0c2a9d8f9d4521aab5d69..3135db022939b822b0331cfbac78b2b22942cc5c 100644
--- a/test/unittests/compiler/bytecode-graph-builder-unittest.cc
+++ b/test/unittests/compiler/bytecode-graph-builder-unittest.cc
@@ -40,12 +40,6 @@
public:
BytecodeGraphBuilderTest() {}
- std::pair<Graph*, Handle<SharedFunctionInfo>> GetCompletedGraphAndSharedInfo(
- Handle<BytecodeArray> bytecode_array,
- MaybeHandle<TypeFeedbackVector> feedback_vector =
- MaybeHandle<TypeFeedbackVector>(),
- LanguageMode language_mode = LanguageMode::SLOPPY);
-
Graph* GetCompletedGraph(Handle<BytecodeArray> bytecode_array,
MaybeHandle<TypeFeedbackVector> feedback_vector =
MaybeHandle<TypeFeedbackVector>(),
@@ -69,8 +63,7 @@
};
-std::pair<Graph*, Handle<SharedFunctionInfo>>
-BytecodeGraphBuilderTest::GetCompletedGraphAndSharedInfo(
+Graph* BytecodeGraphBuilderTest::GetCompletedGraph(
Handle<BytecodeArray> bytecode_array,
MaybeHandle<TypeFeedbackVector> feedback_vector,
LanguageMode language_mode) {
@@ -98,17 +91,7 @@
BytecodeGraphBuilder graph_builder(zone(), &info, jsgraph);
graph_builder.CreateGraph();
- return std::make_pair(graph_builder.graph(), shared_info);
-}
-
-
-Graph* BytecodeGraphBuilderTest::GetCompletedGraph(
- Handle<BytecodeArray> bytecode_array,
- MaybeHandle<TypeFeedbackVector> feedback_vector,
- LanguageMode language_mode) {
- return GetCompletedGraphAndSharedInfo(bytecode_array, feedback_vector,
- language_mode)
- .first;
+ return graph;
}
@@ -824,39 +807,6 @@
EXPECT_THAT(ret, IsReturn(call_construct, call_construct, IsIfSuccess(_)));
}
-
-TEST_F(BytecodeGraphBuilderTest, CreateClosure) {
- PretenureFlag kPretenureFlags[] = {NOT_TENURED, TENURED};
- TRACED_FOREACH(PretenureFlag, pretenure_flag, kPretenureFlags) {
- interpreter::BytecodeArrayBuilder inner_builder(isolate(), zone());
- inner_builder.set_locals_count(0);
- inner_builder.set_context_count(0);
- inner_builder.set_parameter_count(3);
- inner_builder.LoadAccumulatorWithRegister(inner_builder.Parameter(2))
- .BinaryOperation(Token::Value::ADD, inner_builder.Parameter(1),
- Strength::WEAK)
- .Return();
-
- std::pair<Graph*, Handle<SharedFunctionInfo>> inner_graph_and_shared_info =
- GetCompletedGraphAndSharedInfo(inner_builder.ToBytecodeArray());
- Handle<SharedFunctionInfo> shared_info = inner_graph_and_shared_info.second;
-
- interpreter::BytecodeArrayBuilder builder(isolate(), zone());
- builder.set_locals_count(4);
- builder.set_context_count(0);
- builder.set_parameter_count(3);
- builder.CreateClosure(shared_info, pretenure_flag).Return();
-
- Graph* graph = GetCompletedGraph(builder.ToBytecodeArray());
- Node* start = graph->start();
- Node* ret = graph->end()->InputAt(0);
-
- Matcher<Node*> create_closure =
- IsCreateClosure(shared_info, pretenure_flag, start, start);
- EXPECT_THAT(ret, IsReturn(create_closure, create_closure, start));
- }
-}
-
} // namespace compiler
} // namespace internal
} // namespace v8
« no previous file with comments | « test/cctest/interpreter/test-bytecode-generator.cc ('k') | test/unittests/compiler/node-test-utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698