Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: test/unittests/compiler/node-test-utils.cc

Issue 1471913004: Revert of [Interpreter] Add CreateClosure to BytecodeGraphBuilder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/compiler/node-test-utils.cc
diff --git a/test/unittests/compiler/node-test-utils.cc b/test/unittests/compiler/node-test-utils.cc
index 5128fd2c7350fc6defb6d603415a8b16944d7bd3..713a4bc440889231b58a93f42e8490898c1442b7 100644
--- a/test/unittests/compiler/node-test-utils.cc
+++ b/test/unittests/compiler/node-test-utils.cc
@@ -26,7 +26,6 @@
bool operator==(Handle<HeapObject> const& lhs, Handle<HeapObject> const& rhs) {
return lhs.is_identical_to(rhs);
}
-
namespace compiler {
@@ -1855,56 +1854,6 @@
private:
const std::vector<Matcher<Node*>> value_matchers_;
- const Matcher<Node*> effect_matcher_;
- const Matcher<Node*> control_matcher_;
-};
-
-
-class IsCreateClosureMatcher final : public NodeMatcher {
- public:
- IsCreateClosureMatcher(
- const Matcher<Handle<SharedFunctionInfo>>& shared_info_matcher,
- const Matcher<PretenureFlag>& pretenure_matcher,
- const Matcher<Node*>& effect_matcher,
- const Matcher<Node*>& control_matcher)
- : NodeMatcher(IrOpcode::Value::kJSCreateClosure),
- shared_info_matcher_(shared_info_matcher),
- pretenure_matcher_(pretenure_matcher),
- effect_matcher_(effect_matcher),
- control_matcher_(control_matcher) {}
-
- void DescribeTo(std::ostream* os) const final {
- NodeMatcher::DescribeTo(os);
- *os << " whose value (";
- shared_info_matcher_.DescribeTo(os);
- *os << ",";
- pretenure_matcher_.DescribeTo(os);
- *os << "), effect (";
- effect_matcher_.DescribeTo(os);
- *os << ") and control (";
- control_matcher_.DescribeTo(os);
- *os << ")";
- }
-
- bool MatchAndExplain(Node* node, MatchResultListener* listener) const final {
- if (!NodeMatcher::MatchAndExplain(node, listener)) {
- return false;
- }
- return (PrintMatchAndExplain(
- OpParameter<const CreateClosureParameters>(node).shared_info(),
- "value", shared_info_matcher_, listener) &&
- PrintMatchAndExplain(
- OpParameter<CreateClosureParameters>(node).pretenure(), "value",
- pretenure_matcher_, listener) &&
- PrintMatchAndExplain(NodeProperties::GetEffectInput(node), "effect",
- effect_matcher_, listener) &&
- PrintMatchAndExplain(NodeProperties::GetControlInput(node),
- "control", control_matcher_, listener));
- }
-
- private:
- const Matcher<Handle<SharedFunctionInfo>> shared_info_matcher_;
- const Matcher<PretenureFlag> pretenure_matcher_;
const Matcher<Node*> effect_matcher_;
const Matcher<Node*> control_matcher_;
};
@@ -2583,15 +2532,6 @@
return MakeMatcher(new IsJSCallMatcher(IrOpcode::kJSCallRuntime,
value_matchers, effect_matcher,
control_matcher));
-}
-
-
-Matcher<Node*> IsCreateClosure(const Handle<SharedFunctionInfo> shared_info,
- PretenureFlag pretenure,
- const Matcher<Node*>& effect_matcher,
- const Matcher<Node*>& control_matcher) {
- return MakeMatcher(new IsCreateClosureMatcher(
- shared_info, pretenure, effect_matcher, control_matcher));
}
« no previous file with comments | « test/unittests/compiler/node-test-utils.h ('k') | test/unittests/interpreter/bytecode-array-builder-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698