Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Issue 1471513002: Revert of option to quick-accept clipRect calls (Closed)

Created:
5 years, 1 month ago by bsalomon
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of option to quick-accept clipRect calls (patchset #3 id:40001 of https://codereview.chromium.org/1458913005/ ) Reason for revert: Breaking tests on Android: D/skia ( 4469): D/skia ( 4469): Failures: D/skia ( 4469): ../../../tests/CanvasStateTest.cpp:325 clipStackBounds.width() == WIDTH D/skia ( 4469): ../../../tests/CanvasStateTest.cpp:326 clipStackBounds.height() == HEIGHT D/skia ( 4469): 2 failures http://build.chromium.org/p/client.skia.android/builders/Test-Android-GCC-NexusPlayer-CPU-SSE4-x86-Debug/builds/1387/steps/dm/logs/stdio Original issue's description: > option to quick-accept clipRect calls > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/90ba095c459e38581353073826785074b5953b8c TBR=robertphillips@google.com,fmalita@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/ac8cabd729c75fdf774c0701b6ea7fd3ea5b9382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -34 lines) Patch
M src/core/SkCanvas.cpp View 1 chunk +14 lines, -34 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Created Revert of option to quick-accept clipRect calls
5 years, 1 month ago (2015-11-21 02:52:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471513002/1
5 years, 1 month ago (2015-11-21 02:53:04 UTC) #2
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 02:53:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ac8cabd729c75fdf774c0701b6ea7fd3ea5b9382

Powered by Google App Engine
This is Rietveld 408576698