Add parsing for named grid lines

Add parsing for named grid lines

This extends our grammar to support named grid lines (no support
for named grid lines with 'span' yet, though the testing for that
is added as part of this change).

The idea is that we convert the existing "integer position" into an
explicit position that covers [ <integer> || <string> ] in the
grammar. Also to simplify StyleResolver, we always create a
CSSValueList with the different values in a well-defined order.

The grid-item-*-get-set.html tests were improved to support the
extended grammar and some clean-up was done in the invalid cases
in grid-item-column-row-get-set.html as a lot of them could fail
for 2 reasons (both positions are span and another one).

BUG=234192
TESTS=fast/css-grid-layout/grid-item-column-row-get-set.html
      fast/css-grid-layout/grid-item-end-after-get-set.html
      fast/css-grid-layout/grid-item-start-before-get-set.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150381

[Julien - ping for review, 2013-05-09 21:48:42]

https://codereview.chromium.org/14715014/diff/1/Source/core/css/CSSParser.cpp
File Source/core/css/CSSParser.cpp (right):

https://codereview.chromium.org/14715014/diff/1/Source/core/css/CSSParser.cpp...
Source/core/css/CSSParser.cpp:4565: } else if (value->unit ==
CSSPrimitiveValue::CSS_STRING) {
This change doesn't match the description unfortunately (extending the grammar
to parse [ <string> || <integer> ]. I did a bad job at splitting the existing
patch (that also covers the 'span' case). Let me see what I can do about that.

[Julien - ping for review, 2013-05-10 14:36:01]

The new patchset matches the syntax properly (woohoo!). It introduces some
temporary code duplication that will be removed when we add parsing for named
grid lines with 'span' (covered by a FIXME in the code).

[Julien - ping for review, 2013-05-14 21:44:34]

Reviewer ping!

[esprehn, 2013-05-14 21:52:27]

LGTM. This looks okay, but I'm somewhat confused at how named grid lines work. I
thought we need to keep them in a map somewhere to be able to know what the real
position is when someone uses the named line.

https://codereview.chromium.org/14715014/diff/3002/Source/core/css/CSSParser.cpp
File Source/core/css/CSSParser.cpp (right):

https://codereview.chromium.org/14715014/diff/3002/Source/core/css/CSSParser....
Source/core/css/CSSParser.cpp:4606: ASSERT(values->length() > 0);
Usually we just ASSERT(values->length()), no need for the > 0

https://codereview.chromium.org/14715014/diff/3002/Source/core/rendering/styl...
File Source/core/rendering/style/GridPosition.h (right):

https://codereview.chromium.org/14715014/diff/3002/Source/core/rendering/styl...
Source/core/rendering/style/GridPosition.h:56: bool isExplicit() const { return
m_type == ExplicitPosition; }
So nothing actually calls this?

https://codereview.chromium.org/14715014/diff/3002/Source/core/rendering/styl...
Source/core/rendering/style/GridPosition.h:59: void setExplicitPosition(int
position, const String& namedGridLine)
We don't need to keep these in a map somewhere?

[Julien - ping for review, 2013-05-14 22:51:11]

https://codereview.chromium.org/14715014/diff/3002/Source/core/rendering/styl...
File Source/core/rendering/style/GridPosition.h (right):

https://codereview.chromium.org/14715014/diff/3002/Source/core/rendering/styl...
Source/core/rendering/style/GridPosition.h:56: bool isExplicit() const { return
m_type == ExplicitPosition; }
On 2013/05/14 21:52:27, esprehn wrote:
> So nothing actually calls this?

Indeed, the only place calling isInteger was CSSComputedStyleDeclaration.cpp and
we removed the call.

https://codereview.chromium.org/14715014/diff/3002/Source/core/rendering/styl...
Source/core/rendering/style/GridPosition.h:59: void setExplicitPosition(int
position, const String& namedGridLine)
On 2013/05/14 21:52:27, esprehn wrote:
> We don't need to keep these in a map somewhere?

We do but not these ones specifically. This is the grid item's side of the
change where you say in which already-defined named grid line you should go.

The code for keeping track of the defined named grid lines has already landed in
https://codereview.chromium.org/14786002/.

[commit-bot: I haz the power, 2013-05-14 22:59:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/14715014/18001

[commit-bot: I haz the power, 2013-05-14 23:25:00]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_layout.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-14 23:37:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/14715014/18001

[commit-bot: I haz the power, 2013-05-15 00:12:52]

Change committed as 150381