Add parsing for named grid lines

Source/core/rendering/style/GridPosition.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef GridPosition_h
 #define GridPosition_h
 
+#include "wtf/text/WTFString.h"
+
 namespace WebCore {
 
 enum GridPositionType {
     AutoPosition,
-    IntegerPosition,
+    ExplicitPosition, // [ <integer> || <string> ]
     SpanPosition
 };
 
 class GridPosition {
 public:
     GridPosition()
         : m_type(AutoPosition)
         , m_integerPosition(0)
     {
     }
 
     bool isPositive() const { return integerPosition() > 0; }
 
     GridPositionType type() const { return m_type; }
     bool isAuto() const { return m_type == AutoPosition; }
-    bool isInteger() const { return m_type == IntegerPosition; }
+    bool isExplicit() const { return m_type == ExplicitPosition; }

[esprehn, 2013/05/14 21:52:27]

So nothing actually calls this?

[Julien - ping for review, 2013/05/14 22:51:11]

Indeed, the only place calling isInteger was CSSComputedStyleDeclaration.cpp and
we removed the call.

     bool isSpan() const { return m_type == SpanPosition; }
 
-    void setIntegerPosition(int position)
+    void setExplicitPosition(int position, const String& namedGridLine)

[esprehn, 2013/05/14 21:52:27]

We don't need to keep these in a map somewhere?

[Julien - ping for review, 2013/05/14 22:51:11]

We do but not these ones specifically. This is the grid item's side of the
change where you say in which already-defined named grid line you should go.

The code for keeping track of the defined named grid lines has already landed in
https://codereview.chromium.org/14786002/.

     {
-        m_type = IntegerPosition;
+        m_type = ExplicitPosition;
         m_integerPosition = position;
+        m_namedGridLine = namedGridLine;
     }
 
     // 'span' values cannot be negative, yet we reuse the <integer> position which can
     // be. This means that we have to convert the span position to an integer, losing
     // some precision here. It shouldn't be an issue in practice though.
     void setSpanPosition(int position)
     {
         m_type = SpanPosition;
         m_integerPosition = position;
     }
 
     int integerPosition() const
     {
-        ASSERT(type() == IntegerPosition);
+        ASSERT(type() == ExplicitPosition);
         return m_integerPosition;
     }
 
+    String namedGridLine() const
+    {
+        ASSERT(type() == ExplicitPosition);
+        return m_namedGridLine;
+    }
+
     int spanPosition() const
     {
         ASSERT(type() == SpanPosition);
         return m_integerPosition;
     }
 
     bool operator==(const GridPosition& other) const
     {
         return m_type == other.m_type && m_integerPosition == other.m_integerPosition;
     }
 
     bool shouldBeResolvedAgainstOppositePosition() const
     {
         return isAuto() || isSpan();
     }
 private:
     GridPositionType m_type;
     int m_integerPosition;
+    String m_namedGridLine;
 };
 
 } // namespace WebCore
 
 #endif // GridPosition_h