Source/core/rendering/RenderGrid.cpp - Issue 14715014: Add parsing for named grid lines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderGrid.cpp

Issue 14715014: Add parsing for named grid lines (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Patch for landing (fixed Elliott's comments) Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderGrid.cpp

diff --git a/Source/core/rendering/RenderGrid.cpp b/Source/core/rendering/RenderGrid.cpp

index 885fac5025968f766028d8d342d929f87c78ac96..529ea415037139ac91a60495a502dfa7f83f48d1 100644

--- a/Source/core/rendering/RenderGrid.cpp

+++ b/Source/core/rendering/RenderGrid.cpp

@@ -861,7 +861,7 @@ size_t RenderGrid::resolveGridPositionFromStyle(const GridPosition& position, Gr

{

// FIXME: Handle other values for grid-{row,column} like ranges or line names.

switch (position.type()) {

- case IntegerPosition: {

+ case ExplicitPosition: {

if (position.isPositive()) {

if (side == EndSide || side == AfterSide)

return std::max(0, position.integerPosition() - 2);