Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1471353002: Paint red fill after checking CachedDisplayItemList (Closed)

Created:
5 years ago by Xianzhu
Modified:
5 years ago
Reviewers:
pdr., chrishtr
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Paint red fill after checking CachedDisplayItemList This simplifies the code handling CachedDisplayItemList. Committed: https://crrev.com/2f0c19897d949aa9ff5249ed757fa4fc6922bcdc Cr-Commit-Position: refs/heads/master@{#361535}

Patch Set 1 #

Patch Set 2 : Rebase on https://codereview.chromium.org/1469123005/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 1 2 chunks +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Issue 1469123005 Patch 1

Messages

Total messages: 13 (6 generated)
Xianzhu
5 years ago (2015-11-24 18:46:05 UTC) #2
chrishtr
lgtm
5 years ago (2015-11-24 18:49:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471353002/1
5 years ago (2015-11-24 18:49:28 UTC) #6
Xianzhu
This needs to be rebased on https://codereview.chromium.org/1469123005/.
5 years ago (2015-11-24 18:50:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471353002/20001
5 years ago (2015-11-24 23:41:06 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-25 03:13:49 UTC) #12
commit-bot: I haz the power
5 years ago (2015-11-25 03:15:39 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2f0c19897d949aa9ff5249ed757fa4fc6922bcdc
Cr-Commit-Position: refs/heads/master@{#361535}

Powered by Google App Engine
This is Rietveld 408576698