Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

Issue 1471353002: Paint red fill after checking CachedDisplayItemList (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase on https://codereview.chromium.org/1469123005/ Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "platform/graphics/paint/PaintController.h" 6 #include "platform/graphics/paint/PaintController.h"
7 7
8 #include "platform/NotImplemented.h" 8 #include "platform/NotImplemented.h"
9 #include "platform/TraceEvent.h" 9 #include "platform/TraceEvent.h"
10 #include "platform/graphics/GraphicsLayer.h" 10 #include "platform/graphics/GraphicsLayer.h"
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 void PaintController::commitNewDisplayItems() 277 void PaintController::commitNewDisplayItems()
278 { 278 {
279 TRACE_EVENT2("blink,benchmark", "PaintController::commitNewDisplayItems", 279 TRACE_EVENT2("blink,benchmark", "PaintController::commitNewDisplayItems",
280 "current_display_list_size", (int)m_currentPaintArtifact.displayItemList ().size(), 280 "current_display_list_size", (int)m_currentPaintArtifact.displayItemList ().size(),
281 "num_non_cached_new_items", (int)m_newDisplayItemList.size() - m_numCach edItems); 281 "num_non_cached_new_items", (int)m_newDisplayItemList.size() - m_numCach edItems);
282 282
283 if (RuntimeEnabledFeatures::slimmingPaintSynchronizedPaintingEnabled() 283 if (RuntimeEnabledFeatures::slimmingPaintSynchronizedPaintingEnabled()
284 && !m_newDisplayItemList.isEmpty() 284 && !m_newDisplayItemList.isEmpty()
285 && m_newDisplayItemList.last().type() == DisplayItem::CachedDisplayItemL ist) { 285 && m_newDisplayItemList.last().type() == DisplayItem::CachedDisplayItemL ist) {
286 // The whole display item list is cached. 286 // The whole display item list is cached.
287 ASSERT(m_newDisplayItemList.size() == 1 287 ASSERT(m_newDisplayItemList.size() == 1);
288 || (m_newDisplayItemList.size() == 2 && DisplayItem::nonCachedType(m _newDisplayItemList[0].type()) == DisplayItem::DebugRedFill));
289 ASSERT(m_invalidations.isEmpty()); 288 ASSERT(m_invalidations.isEmpty());
290 ASSERT(m_clientsCheckedPaintInvalidation.isEmpty()); 289 ASSERT(m_clientsCheckedPaintInvalidation.isEmpty());
291 m_newDisplayItemList.clear(); 290 m_newDisplayItemList.clear();
292 m_newPaintChunks.clear(); 291 m_newPaintChunks.clear();
293 return; 292 return;
294 } 293 }
295 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) 294 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
296 m_clientsCheckedPaintInvalidation.clear(); 295 m_clientsCheckedPaintInvalidation.clear();
297 296
298 // These data structures are used during painting only. 297 // These data structures are used during painting only.
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
569 568
570 void PaintController::showDebugData() const 569 void PaintController::showDebugData() const
571 { 570 {
572 WTFLogAlways("current display item list: [%s]\n", displayItemListAsDebugStri ng(m_currentPaintArtifact.displayItemList()).utf8().data()); 571 WTFLogAlways("current display item list: [%s]\n", displayItemListAsDebugStri ng(m_currentPaintArtifact.displayItemList()).utf8().data());
573 WTFLogAlways("new display item list: [%s]\n", displayItemListAsDebugString(m _newDisplayItemList).utf8().data()); 572 WTFLogAlways("new display item list: [%s]\n", displayItemListAsDebugString(m _newDisplayItemList).utf8().data());
574 } 573 }
575 574
576 #endif // ifndef NDEBUG 575 #endif // ifndef NDEBUG
577 576
578 } // namespace blink 577 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698