Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1469123005: Always use own PaintController in GraphicsLayer::paint() (Closed)

Created:
5 years ago by Xianzhu
Modified:
5 years ago
Reviewers:
chrishtr
CC:
apavlov+blink_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, caseq+blink_chromium.org, chromium-reviews, danakj, devtools-reviews_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pdr+graphicswatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always use own PaintController in GraphicsLayer::paint() BUG=536999 TEST=inspector-protocol/layers/paint-profiler.html R=chrishtr@chromium.org Committed: https://crrev.com/3685127440849ec24dc0f14d45b70b060f2e4657 Cr-Commit-Position: refs/heads/master@{#361486}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 1471353002 Patch 20001

Messages

Total messages: 12 (4 generated)
Xianzhu
5 years ago (2015-11-24 18:41:38 UTC) #2
chrishtr
Other uses of SkPictureBuilder are ok? e.g. dragImage, page overlays?
5 years ago (2015-11-24 18:44:48 UTC) #3
Xianzhu
On 2015/11/24 18:44:48, chrishtr wrote: > Other uses of SkPictureBuilder are ok? e.g. dragImage, page ...
5 years ago (2015-11-24 18:45:31 UTC) #4
chrishtr
lgtm
5 years ago (2015-11-24 18:46:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469123005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469123005/1
5 years ago (2015-11-24 18:49:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/100787)
5 years ago (2015-11-24 20:59:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469123005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469123005/1
5 years ago (2015-11-24 22:11:53 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-24 23:37:56 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3685127440849ec24dc0f14d45b70b060f2e4657
Cr-Commit-Position: refs/heads/master@{#361486}

Powered by Google App Engine
This is Rietveld 408576698