Create a static instances of SrcOver XferProcessor

Create a static instances of SrcOver XferProcessor

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/56cf6dcb6572f1d355af041c1ebf157b2b3d0165

[egdaniel, 2015-11-24 17:22:30]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@chromium.org

[egdaniel, 2015-11-24 17:22:31]

Here's a change to create a static SrcOver XP. The big change is that knowing
whether or not we are using coverage in the shader is not stored on the pipeline
and not the XP. This was needed since the reading/not reading the coverage is
draw dependent (outside of the XP creation) which obviously won't work for our
static.

[joshualitt, 2015-11-30 15:51:49]

On 2015/11/24 17:22:31, egdaniel wrote:
> Here's a change to create a static SrcOver XP. The big change is that knowing
> whether or not we are using coverage in the shader is not stored on the
pipeline
> and not the XP. This was needed since the reading/not reading the coverage is
> draw dependent (outside of the XP creation) which obviously won't work for our
> static.

this looks good, Brian any thoughts?

[bsalomon, 2015-11-30 15:56:53]

https://codereview.chromium.org/1471293003/diff/20001/src/gpu/GrPipeline.h
File src/gpu/GrPipeline.h (right):

https://codereview.chromium.org/1471293003/diff/20001/src/gpu/GrPipeline.h#ne...
src/gpu/GrPipeline.h:184: bool                                fReadsCoverage; //
Will this program use coverage?
Given that this is now moved from XP to Pipeline, maybe it should a new name
that is more explicit? fXPUsesCoverage?

[egdaniel, 2015-11-30 16:29:14]

https://codereview.chromium.org/1471293003/diff/20001/src/gpu/GrPipeline.h
File src/gpu/GrPipeline.h (right):

https://codereview.chromium.org/1471293003/diff/20001/src/gpu/GrPipeline.h#ne...
src/gpu/GrPipeline.h:184: bool                                fReadsCoverage; //
Will this program use coverage?
On 2015/11/30 15:56:53, bsalomon wrote:
> Given that this is now moved from XP to Pipeline, maybe it should a new name
> that is more explicit? fXPUsesCoverage? 

Done.

[bsalomon, 2015-11-30 16:51:27]

lgtm

[egdaniel, 2015-11-30 17:53:50]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2015-11-30 17:53:50]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1471293003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2015-11-30 17:54:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471293003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471293003/60001

[commit-bot: I haz the power, 2015-11-30 17:56:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-30 17:56:22]

Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[egdaniel, 2015-11-30 18:01:04]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2015-11-30 18:01:04]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1471293003/#ps80001
(title: "Fix Build")

[commit-bot: I haz the power, 2015-11-30 18:01:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471293003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471293003/80001

[commit-bot: I haz the power, 2015-11-30 18:16:00]

Description was changed from

==========
Create a static instances of SrcOver XferProcessor

BUG=skia:
==========

to

==========
Create a static instances of SrcOver XferProcessor

BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/56cf6dcb6572f1d355af041c1ebf157b2b3d0165
==========

[commit-bot: I haz the power, 2015-11-30 18:16:01]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/56cf6dcb6572f1d355af041c1ebf157b2b3d0165

[scroggo, 2015-12-01 12:42:46]

On 2015/11/30 18:16:01, commit-bot: I haz the power wrote:
> Committed patchset #5 (id:80001) as
> https://skia.googlesource.com/skia/+/56cf6dcb6572f1d355af041c1ebf157b2b3d0165

Could this have provided a speed up? https://perf.skia.org/cl/1007