Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/core/SkXfermode.cpp

Issue 1471053002: Don't create a GXPFactory when blend is SrcOver (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: nit Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« include/gpu/effects/GrPorterDuffXferProcessor.h ('K') | « src/core/SkImageFilter.cpp ('k') | src/effects/SkArithmeticMode_gpu.h » ('j') | src/gpu/GrPipeline.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkXfermode.cpp
diff --git a/src/core/SkXfermode.cpp b/src/core/SkXfermode.cpp
index 9083814d1a66b97a00e05436f0dd8e7c61ab44ee..2d3f0dac036e05f989426b182ab3c5b893704577 100644
--- a/src/core/SkXfermode.cpp
+++ b/src/core/SkXfermode.cpp
@@ -667,7 +667,7 @@ bool SkXfermode::asXPFactory(GrXPFactory**) const {
bool SkXfermode::AsXPFactory(SkXfermode* xfermode, GrXPFactory** xpf) {
bsalomon 2015/11/23 20:19:52 should we inline the top part of this function in
egdaniel 2015/11/23 20:49:04 Done.
if (nullptr == xfermode) {
if (xpf) {
- *xpf = GrPorterDuffXPFactory::Create(kSrcOver_Mode);
+ *xpf = nullptr;
}
return true;
} else {
« include/gpu/effects/GrPorterDuffXferProcessor.h ('K') | « src/core/SkImageFilter.cpp ('k') | src/effects/SkArithmeticMode_gpu.h » ('j') | src/gpu/GrPipeline.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698