Don't create a GXPFactory when blend is SrcOver

src/core/SkXfermode.cpp

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkXfermode.h"
 #include "SkXfermode_proccoeff.h"
@@ skipping 646 matching lines @@
 }
 
 bool SkXfermode::asXPFactory(GrXPFactory**) const {
     return false;
 }
 
 
 #if SK_SUPPORT_GPU
 #include "effects/GrPorterDuffXferProcessor.h"
 
 bool SkXfermode::AsXPFactory(SkXfermode* xfermode, GrXPFactory** xpf) {

[bsalomon, 2015/11/23 20:19:52]

should we inline the top part of this function in SkXfermode.h?

[egdaniel, 2015/11/23 20:49:04]

Done.

     if (nullptr == xfermode) {
         if (xpf) {
-            *xpf = GrPorterDuffXPFactory::Create(kSrcOver_Mode);
+            *xpf = nullptr;
         }
         return true;
     } else {
         return xfermode->asXPFactory(xpf);
     }
 }
 #else
 bool SkXfermode::AsXPFactory(SkXfermode* xfermode, GrXPFactory** xpf) {
     return false;
 }
@@ skipping 402 matching lines @@
     if (!xfer) {
         return SkXfermode::kOpaque_SrcColorOpacity == opacityType;
     }
 
     return xfer->isOpaque(opacityType);
 }
 
 SK_DEFINE_FLATTENABLE_REGISTRAR_GROUP_START(SkXfermode)
     SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(SkProcCoeffXfermode)
 SK_DEFINE_FLATTENABLE_REGISTRAR_GROUP_END