src/core/SkImageFilter.cpp - Issue 1471053002: Don't create a GXPFactory when blend is SrcOver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkImageFilter.cpp

Issue 1471053002: Don't create a GXPFactory when blend is SrcOver (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: nit Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkImageFilter.cpp

diff --git a/src/core/SkImageFilter.cpp b/src/core/SkImageFilter.cpp

index abac24cf3fa145044f11f32e307bde1fbfb28a2b..6a3286ed67475510be347379142f35d8084cc5df 100644

--- a/src/core/SkImageFilter.cpp

+++ b/src/core/SkImageFilter.cpp

@@ -377,6 +377,7 @@ bool SkImageFilter::filterImageGPU(Proxy* proxy, const SkBitmap& src, const Cont

if (this->asFragmentProcessor(&fp, srcTexture, matrix, bounds)) {

SkASSERT(fp);

paint.addColorFragmentProcessor(fp)->unref();

+ paint.setPorterDuffXPFactory(SkXfermode::kSrc_Mode);

SkAutoTUnref<GrDrawContext> drawContext(context->drawContext(dst->asRenderTarget()));

if (drawContext) {