Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1471043004: Convert various vector_as_array calls to vector::data. (Closed)

Created:
5 years ago by davidben
Modified:
5 years ago
CC:
avayvod+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, eme-reviews_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, kalyank, mcasas+watch_chromium.org, mlamouri+watch-media_chromium.org, ozone-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, scheib+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert various vector_as_array calls to vector::data. This gets everything that wasn't covered by a previous CL in flight. BUG=556678 TBR=zea@chromium.org Committed: https://crrev.com/b50f00c17dac2371146653d82acef7338f386d8c Cr-Commit-Position: refs/heads/master@{#362283}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -91 lines) Patch
M device/bluetooth/dbus/bluetooth_le_advertisement_service_provider.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M device/serial/buffer.cc View 2 chunks +1 line, -2 lines 0 comments Download
M extensions/browser/api/capture_web_contents_function.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/hid/hid_api.cc View 2 chunks +1 line, -2 lines 0 comments Download
M extensions/browser/api/networking_config/networking_config_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/browser/updater/update_data_provider.cc View 2 chunks +1 line, -2 lines 0 comments Download
M extensions/renderer/module_system.cc View 2 chunks +1 line, -3 lines 0 comments Download
M extensions/renderer/module_system_test.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M google_apis/gcm/base/socket_stream_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M media/base/android/media_drm_bridge.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M media/base/android/webaudio_media_codec_bridge.cc View 2 chunks +1 line, -2 lines 0 comments Download
M media/blink/webcontentdecryptionmodulesession_impl.cc View 2 chunks +1 line, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cdm/cdm_adapter.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M media/cdm/cenc_utils.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M media/cdm/proxy_decryptor.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 2 chunks +1 line, -2 lines 0 comments Download
M remoting/host/touch_injector_win.cc View 5 chunks +4 lines, -9 lines 0 comments Download
M tools/json_schema_compiler/cc_generator.py View 2 chunks +2 lines, -5 lines 0 comments Download
M tools/json_schema_compiler/util.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ui/ozone/platform/headless/headless_surface_factory.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
davidben
rockot for devices/ and extensions/ zea for google_apis/gcm/ dalecurtis for media/ raymes for ppapi/ wez ...
5 years ago (2015-11-24 22:13:51 UTC) #2
DaleCurtis
media/ lgtm
5 years ago (2015-11-24 22:15:50 UTC) #3
Wez
remoting/ LGTM
5 years ago (2015-11-24 22:22:13 UTC) #4
Ken Rockot(use gerrit already)
extension and device lgtm
5 years ago (2015-11-24 22:30:50 UTC) #5
raymes
ppapi/ lgtm
5 years ago (2015-11-24 23:29:15 UTC) #6
spang
ui/ozone lgtm
5 years ago (2015-11-25 02:26:11 UTC) #7
Nico
tools lgtm
5 years ago (2015-11-25 15:30:06 UTC) #8
davidben
(zea@ to TBR since this is a totally mechanical CL. Also gave the relevant file ...
5 years ago (2015-11-30 21:25:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471043004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471043004/20001
5 years ago (2015-11-30 21:27:29 UTC) #12
Nicolas Zea
gcm lgtm
5 years ago (2015-11-30 21:30:22 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-01 00:02:02 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-01 00:02:58 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b50f00c17dac2371146653d82acef7338f386d8c
Cr-Commit-Position: refs/heads/master@{#362283}

Powered by Google App Engine
This is Rietveld 408576698