Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: extensions/renderer/module_system_test.cc

Issue 1471043004: Convert various vector_as_array calls to vector::data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/renderer/module_system.cc ('k') | google_apis/gcm/base/socket_stream_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/module_system_test.h" 5 #include "extensions/renderer/module_system_test.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/files/file_path.h" 11 #include "base/files/file_path.h"
12 #include "base/files/file_util.h" 12 #include "base/files/file_util.h"
13 #include "base/lazy_instance.h" 13 #include "base/lazy_instance.h"
14 #include "base/memory/scoped_ptr.h" 14 #include "base/memory/scoped_ptr.h"
15 #include "base/path_service.h" 15 #include "base/path_service.h"
16 #include "base/stl_util.h"
17 #include "base/strings/string_piece.h" 16 #include "base/strings/string_piece.h"
18 #include "extensions/common/extension_paths.h" 17 #include "extensions/common/extension_paths.h"
19 #include "extensions/renderer/logging_native_handler.h" 18 #include "extensions/renderer/logging_native_handler.h"
20 #include "extensions/renderer/object_backed_native_handler.h" 19 #include "extensions/renderer/object_backed_native_handler.h"
21 #include "extensions/renderer/safe_builtins.h" 20 #include "extensions/renderer/safe_builtins.h"
22 #include "extensions/renderer/utils_native_handler.h" 21 #include "extensions/renderer/utils_native_handler.h"
23 #include "ui/base/resource/resource_bundle.h" 22 #include "ui/base/resource/resource_bundle.h"
24 23
25 namespace extensions { 24 namespace extensions {
26 namespace { 25 namespace {
27 26
28 class FailsOnException : public ModuleSystem::ExceptionHandler { 27 class FailsOnException : public ModuleSystem::ExceptionHandler {
29 public: 28 public:
30 FailsOnException() : ModuleSystem::ExceptionHandler(nullptr) {} 29 FailsOnException() : ModuleSystem::ExceptionHandler(nullptr) {}
31 void HandleUncaughtException(const v8::TryCatch& try_catch) override { 30 void HandleUncaughtException(const v8::TryCatch& try_catch) override {
32 FAIL() << "Uncaught exception: " << CreateExceptionString(try_catch); 31 FAIL() << "Uncaught exception: " << CreateExceptionString(try_catch);
33 } 32 }
34 }; 33 };
35 34
36 class V8ExtensionConfigurator { 35 class V8ExtensionConfigurator {
37 public: 36 public:
38 V8ExtensionConfigurator() 37 V8ExtensionConfigurator()
39 : safe_builtins_(SafeBuiltins::CreateV8Extension()), 38 : safe_builtins_(SafeBuiltins::CreateV8Extension()),
40 names_(1, safe_builtins_->name()), 39 names_(1, safe_builtins_->name()),
41 configuration_( 40 configuration_(
42 new v8::ExtensionConfiguration(static_cast<int>(names_.size()), 41 new v8::ExtensionConfiguration(static_cast<int>(names_.size()),
43 vector_as_array(&names_))) { 42 names_.data())) {
44 v8::RegisterExtension(safe_builtins_.get()); 43 v8::RegisterExtension(safe_builtins_.get());
45 } 44 }
46 45
47 v8::ExtensionConfiguration* GetConfiguration() { 46 v8::ExtensionConfiguration* GetConfiguration() {
48 return configuration_.get(); 47 return configuration_.get();
49 } 48 }
50 49
51 private: 50 private:
52 scoped_ptr<v8::Extension> safe_builtins_; 51 scoped_ptr<v8::Extension> safe_builtins_;
53 std::vector<const char*> names_; 52 std::vector<const char*> names_;
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 247
249 void ModuleSystemTest::ExpectNoAssertionsMade() { 248 void ModuleSystemTest::ExpectNoAssertionsMade() {
250 should_assertions_be_made_ = false; 249 should_assertions_be_made_ = false;
251 } 250 }
252 251
253 void ModuleSystemTest::RunResolvedPromises() { 252 void ModuleSystemTest::RunResolvedPromises() {
254 isolate_->RunMicrotasks(); 253 isolate_->RunMicrotasks();
255 } 254 }
256 255
257 } // namespace extensions 256 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/renderer/module_system.cc ('k') | google_apis/gcm/base/socket_stream_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698