extensions/browser/api/hid/hid_api.cc - Issue 1471043004: Convert various vector_as_array calls to vector::data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/hid/hid_api.cc

Issue 1471043004: Convert various vector_as_array calls to vector::data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/capture_web_contents_function.cc ('k') | extensions/browser/api/networking_config/networking_config_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/hid/hid_api.cc

diff --git a/extensions/browser/api/hid/hid_api.cc b/extensions/browser/api/hid/hid_api.cc

index 1d284a4a32a010fea0d5da0a85a8461e35a21e3a..acd2e93c64f0bee5f48342e64837ee7ddb0dd594 100644

--- a/extensions/browser/api/hid/hid_api.cc

+++ b/extensions/browser/api/hid/hid_api.cc

@@ -7,7 +7,6 @@

#include <string>

#include <vector>

-#include "base/stl_util.h"

#include "device/core/device_client.h"

#include "device/hid/hid_connection.h"

#include "device/hid/hid_device_filter.h"

@@ -346,7 +345,7 @@ void HidSendFeatureReportFunction::StartWork(HidConnection* connection) {

scoped_refptr<net::IOBufferWithSize> buffer(

new net::IOBufferWithSize(parameters_->data.size() + 1));

buffer->data()[0] = static_cast<uint8_t>(parameters_->report_id);

- memcpy(buffer->data() + 1, vector_as_array(&parameters_->data),

+ memcpy(buffer->data() + 1, parameters_->data.data(),

parameters_->data.size());

connection->SendFeatureReport(

buffer, buffer->size(),