Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1470863003: Rework contribution sorter to use futures (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update comment #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1025 lines) Patch
M pkg/analysis_server/lib/src/provisional/completion/completion_core.dart View 2 chunks +0 lines, -29 lines 0 comments Download
D pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart View 1 chunk +0 lines, -162 lines 0 comments Download
D pkg/analysis_server/lib/src/services/completion/common_usage_generated.dart View 1 chunk +0 lines, -427 lines 0 comments Download
D pkg/analysis_server/lib/src/services/completion/contribution_sorter.dart View 1 chunk +0 lines, -26 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart View 3 chunks +9 lines, -7 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.g.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/completion/dart/contribution_sorter.dart View 1 1 chunk +7 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/inherited_contributor.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 6 chunks +15 lines, -43 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 4 chunks +4 lines, -51 lines 0 comments Download
D pkg/analysis_server/test/services/completion/common_usage_computer_test.dart View 1 chunk +0 lines, -256 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/test/services/completion/dart/common_usage_sorter_test.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/inherited_contributor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years ago (2015-11-23 18:51:15 UTC) #2
scheglov
LGTM
5 years ago (2015-11-23 20:29:19 UTC) #3
danrubel
5 years ago (2015-11-24 02:35:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
594183e0db633aebbe84429443958d725cc146b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698