Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Unified Diff: pkg/analysis_server/lib/src/provisional/completion/completion_core.dart

Issue 1470863003: Rework contribution sorter to use futures (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
diff --git a/pkg/analysis_server/lib/src/provisional/completion/completion_core.dart b/pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
index dff6ba6befa2ddbe241596eeee5d9d4332a8738f..7af0ab09bf29702341caac685f1d0416772de8e9 100644
--- a/pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
+++ b/pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
@@ -10,7 +10,6 @@ import 'package:analysis_server/plugin/protocol/protocol.dart';
import 'package:analyzer/file_system/file_system.dart';
import 'package:analyzer/src/generated/engine.dart' show AnalysisContext;
import 'package:analyzer/src/generated/source.dart';
-import 'package:analyzer/task/model.dart';
/**
* An empty list returned by [CompletionContributor]s
@@ -19,34 +18,6 @@ import 'package:analyzer/task/model.dart';
const EMPTY_LIST = const <CompletionSuggestion>[];
/**
- * A method or function called when the requested analysis has been performed.
- */
-typedef AnalysisRequest AnalysisCallback<V>(
- CompletionRequest request, V computedValue);
-
-/**
- * A request from a contributor for additional analysis.
- */
-class AnalysisRequest<V> {
- /**
- * An object with which an analysis result can be associated.
- */
- AnalysisTarget target;
-
- /**
- * A description of an analysis result that can be computed by an [AnalysisTask].
- */
- ResultDescriptor<V> descriptor;
-
- /**
- * A method or function called when the requested analysis has been performed.
- */
- AnalysisCallback<V> callback;
-
- AnalysisRequest(this.target, this.descriptor, this.callback);
-}
-
-/**
* An object used to produce completions at a specific location within a file.
*
* Clients may implement this class when implementing plugins.
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698