Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart

Issue 1470863003: Rework contribution sorter to use futures (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart b/pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart
similarity index 93%
rename from pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart
rename to pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart
index 0faba7710b787001dbfae6cc2ba8e5de3d06d809..fde8bfb2c045b23445e278ab2c90fc3fa2f5ab32 100644
--- a/pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart
@@ -2,14 +2,16 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library services.completion.computer.dart.relevance;
+library services.completion.dart.sorter.common;
+
+import 'dart:async';
import 'package:analysis_server/src/protocol_server.dart' as protocol;
import 'package:analysis_server/src/protocol_server.dart'
show CompletionSuggestion, CompletionSuggestionKind;
import 'package:analysis_server/src/provisional/completion/completion_core.dart';
import 'package:analysis_server/src/provisional/completion/dart/completion_target.dart';
-import 'package:analysis_server/src/services/completion/contribution_sorter.dart';
+import 'package:analysis_server/src/services/completion/dart/contribution_sorter.dart';
import 'package:analysis_server/src/services/completion/dart_completion_manager.dart'
show DART_RELEVANCE_COMMON_USAGE;
import 'package:analyzer/src/generated/ast.dart';
@@ -17,14 +19,14 @@ import 'package:analyzer/src/generated/element.dart';
import 'package:analyzer/src/task/dart.dart';
import 'package:analyzer/task/dart.dart';
-part 'common_usage_generated.dart';
+part 'common_usage_sorter.g.dart';
/**
* A computer for adjusting the relevance of completions computed by others
* based upon common Dart usage patterns. This is a long-lived object
* that should not maintain state between calls to it's [sort] method.
*/
-class CommonUsageComputer implements ContributionSorter {
+class CommonUsageSorter implements DartContributionSorter {
/**
* A map of <library>.<classname> to an ordered list of method names,
* field names, getter names, and named constructors.
@@ -33,13 +35,13 @@ class CommonUsageComputer implements ContributionSorter {
*/
Map<String, List<String>> selectorRelevance;
- CommonUsageComputer([this.selectorRelevance = defaultSelectorRelevance]);
+ CommonUsageSorter([this.selectorRelevance = defaultSelectorRelevance]);
@override
- AnalysisRequest sort(CompletionRequest request,
+ Future sort(CompletionRequest request,
Iterable<CompletionSuggestion> suggestions) {
_update(request, suggestions);
- return null;
+ return new Future.value();
}
CompletionTarget _getCompletionTarget(CompletionRequest request) {

Powered by Google App Engine
This is Rietveld 408576698