Revert Revert of Start calling show/hide onStart/onStop in DocumentActivity)

Revert Revert of Start calling show/hide onStart/onStop in DocumentActivity)

This reverts commit bc113d52b7f5fbf39123f4b43ea779ee2dd587c3.
Moving Show and Hide calls for Tab to WindowFocusChanged for the
activity

BUG=546182
Committed: https://crrev.com/d8dea4977d20235d81b47661beeb8ede158e9a9b
Cr-Commit-Position: refs/heads/master@{#362175}

[Yusuf, 2015-11-24 22:47:22]

The CQ bit was checked by yusufo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-24 22:49:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1470383003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1470383003/20001

[Yusuf, 2015-11-25 00:03:05]

yusufo@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ted C, 2015-11-25 00:47:34]

https://codereview.chromium.org/1470383003/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(left):

https://codereview.chromium.org/1470383003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:630: Tab
tab = getActivityTab();
I think you'll want to keep this around.  I can imagine in samsung multi window
where you could lose window focus first (by switching to a different side by
side app) and then hitting the home button.

In this case, I definitely see the possibility of losing window focus first and
then onStop being called, which would not be handled by this change.

[Yusuf, 2015-11-25 22:04:12]

https://codereview.chromium.org/1470383003/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(left):

https://codereview.chromium.org/1470383003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:630: Tab
tab = getActivityTab();
On 2015/11/25 00:47:34, Ted C wrote:
> I think you'll want to keep this around.  I can imagine in samsung multi
window
> where you could lose window focus first (by switching to a different side by
> side app) and then hitting the home button.
> 
> In this case, I definitely see the possibility of losing window focus first
and
> then onStop being called, which would not be handled by this change.

Done! Also fixed test expectation on two test files.

Also checked that hide and show gets called on lock screen.

[Yusuf, 2015-11-25 22:04:16]

The CQ bit was checked by yusufo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-25 22:09:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1470383003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1470383003/60001

[Ted C, 2015-11-25 22:44:41]

lgtm

https://codereview.chromium.org/1470383003/diff/60001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/1470383003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:644: if
(tab != null && !hasWindowFocus()) tab.onActivityHidden();
you probably "don't" need the hasWindowFocus() check here.

I guess this should ensure a single call to onActivityHidden, but if stop is
called then we are definitely hidden regardless of window focus.

[Yusuf, 2015-11-25 23:42:52]

Description was changed from

==========
Revert Revert of Start calling show/hide onStart/onStop in DocumentActivity)

This reverts commit bc113d52b7f5fbf39123f4b43ea779ee2dd587c3.
Moving Show and Hide calls for Tab to WindowFocusChanged for the
activity

BUG=
==========

to

==========
Revert Revert of Start calling show/hide onStart/onStop in DocumentActivity)

This reverts commit bc113d52b7f5fbf39123f4b43ea779ee2dd587c3.
Moving Show and Hide calls for Tab to WindowFocusChanged for the
activity

BUG=546182
==========

[commit-bot: I haz the power, 2015-11-26 00:15:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 00:15:58]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)

[Yusuf, 2015-11-30 17:57:26]

The CQ bit was checked by yusufo@chromium.org

[commit-bot: I haz the power, 2015-11-30 17:58:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1470383003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1470383003/60001

[commit-bot: I haz the power, 2015-11-30 18:42:48]

Description was changed from

==========
Revert Revert of Start calling show/hide onStart/onStop in DocumentActivity)

This reverts commit bc113d52b7f5fbf39123f4b43ea779ee2dd587c3.
Moving Show and Hide calls for Tab to WindowFocusChanged for the
activity

BUG=546182
==========

to

==========
Revert Revert of Start calling show/hide onStart/onStop in DocumentActivity)

This reverts commit bc113d52b7f5fbf39123f4b43ea779ee2dd587c3.
Moving Show and Hide calls for Tab to WindowFocusChanged for the
activity

BUG=546182
==========

[commit-bot: I haz the power, 2015-11-30 18:42:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-30 18:43:54]

Description was changed from

==========
Revert Revert of Start calling show/hide onStart/onStop in DocumentActivity)

This reverts commit bc113d52b7f5fbf39123f4b43ea779ee2dd587c3.
Moving Show and Hide calls for Tab to WindowFocusChanged for the
activity

BUG=546182
==========

to

==========
Revert Revert of Start calling show/hide onStart/onStop in DocumentActivity)

This reverts commit bc113d52b7f5fbf39123f4b43ea779ee2dd587c3.
Moving Show and Hide calls for Tab to WindowFocusChanged for the
activity

BUG=546182

Committed: https://crrev.com/d8dea4977d20235d81b47661beeb8ede158e9a9b
Cr-Commit-Position: refs/heads/master@{#362175}
==========

[commit-bot: I haz the power, 2015-11-30 18:43:54]

Patchset 4 (id:??) landed as
https://crrev.com/d8dea4977d20235d81b47661beeb8ede158e9a9b
Cr-Commit-Position: refs/heads/master@{#362175}