chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTab.java - Issue 1470383003: Revert Revert of Start calling show/hide onStart/onStop in DocumentActivity)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTab.java

Issue 1470383003: Revert Revert of Start calling show/hide onStart/onStop in DocumentActivity) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failing test expectations Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTab.java b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTab.java

index 39eedff9b1ea0195527f9b31a44a8a8655f92ed3..8108442b711cab340d91f4c1cca9a8da67e16589 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTab.java

@@ -164,13 +164,6 @@ public class DocumentTab extends Tab {

}

- @Override

- public void onActivityStart() {

- // DocumentActivity#onResumeWithNative() will call Tab.show(), and so we don't need to call

- // it at this point.

- onActivityStartInternal(false /* showNow */);

- }

/**

* A helper function to create TabUma and set it to the tab.

* @param creationState In what state the tab was created.