chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java - Issue 1470383003: Revert Revert of Start calling show/hide onStart/onStop in DocumentActivity)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

Issue 1470383003: Revert Revert of Start calling show/hide onStart/onStop in DocumentActivity) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failing test expectations Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

index 14e8814d9223c4dd222e86f844f3d8e226eb339d..5912c2fc089ed8f2e32469683194cc7a04a1d9cf 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

@@ -46,7 +46,6 @@ import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tab.TabUma.TabCreationState;

import org.chromium.chrome.browser.tabmodel.SingleTabModelSelector;

import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;

-import org.chromium.chrome.browser.tabmodel.TabModel.TabSelectionType;

import org.chromium.chrome.browser.tabmodel.document.ActivityDelegate;

import org.chromium.chrome.browser.tabmodel.document.AsyncTabCreationParams;

import org.chromium.chrome.browser.tabmodel.document.AsyncTabCreationParamsManager;

@@ -457,6 +456,7 @@ public class DocumentActivity extends ChromeActivity {

@Override

public void onWindowFocusChanged(boolean hasWindowFocus) {

+ super.onWindowFocusChanged(hasWindowFocus);

if (hasWindowFocus) updateLastTabId();

}

@@ -480,7 +480,6 @@ public class DocumentActivity extends ChromeActivity {

if (asyncParams != null && asyncParams.getLoadUrlParams().getUrl() != null) {

loadLastKnownUrl(asyncParams);

}

- mDocumentTab.show(TabSelectionType.FROM_USER);

}

StartupMetrics.getInstance().recordHistogram(false);

}