[mojo] Enable ServiceRegistryImpl to override remote services

[mojo] Enable ServiceRegistryImpl to override remote services

This adds a new AddServiceOverride method to ServiceRegistryImpl.
The purpose of this is to allow testing code to intercept remote
service connections and opaquely provide a mock implementation of
any service.

The new interface is also added to the ServiceRegistry's JS
bindings.

Committed: https://crrev.com/9b0d7173af550086d5688137752a6f70109e9c98
Cr-Commit-Position: refs/heads/master@{#371736}

[Ken Rockot(use gerrit already), 2015-11-23 23:33:00]

Description was changed from

==========
Allow JS code to intercept and override ServiceRegistry requests.

This adds an OverridableServiceRegistry which RenderFrameImpl uses
to wrap its own registry. This can be used to intercept remote service
requests and provide renderer-side mocks of per-frame browser services.

This also adds some layout tests to test the availability and behavior
of the exposed Mojo EDK modules in content_shell.

This is Nth in a series of patches to do stuff and stuff.
==========

to

==========
Allow JS code to intercept and override ServiceRegistry requests.

This adds an OverridableServiceRegistry which RenderFrameImpl uses
to wrap its own registry. This can be used to intercept remote service
requests and provide renderer-side impls of Mojo services consumed by
render frames.

The ability to intercept and service connection requests is also
exposed through the ServiceRegistry's JS interface.

Finally, this adds some layout tests to verify the availability and
behavior of Mojo EDK modules in content_shell.

Part of a CL series to enable Mojo service mocks in layout tests:

 1. https://codereview.chromium.org/1468903002
 2. https://codereview.chromium.org/1470823002
 3. https://codereview.chromium.org/1464373002
 4. this CL
==========

[Ken Rockot(use gerrit already), 2016-01-24 23:00:00]

Description was changed from

==========
Allow JS code to intercept and override ServiceRegistry requests.

This adds an OverridableServiceRegistry which RenderFrameImpl uses
to wrap its own registry. This can be used to intercept remote service
requests and provide renderer-side impls of Mojo services consumed by
render frames.

The ability to intercept and service connection requests is also
exposed through the ServiceRegistry's JS interface.

Finally, this adds some layout tests to verify the availability and
behavior of Mojo EDK modules in content_shell.

Part of a CL series to enable Mojo service mocks in layout tests:

 1. https://codereview.chromium.org/1468903002
 2. https://codereview.chromium.org/1470823002
 3. https://codereview.chromium.org/1464373002
 4. this CL
==========

to

==========
Allow JS to intercept and override ServiceRegistry requests.

This adds the ability for users of ServiceRegistryImpl to
override remote service requests with local service factories,
a feature that is strictly intended to support sevice mocking
for tests.

This ability is in turn exposed via a new addServiceOverride
binding on the ServiceRegistry's JS interface.

Part of a CL series to enable Mojo service mocks in layout tests:

 1. https://codereview.chromium.org/1468903002
 2. https://codereview.chromium.org/1470823002
 4. this CL
==========

[Ken Rockot(use gerrit already), 2016-01-26 16:23:52]

Description was changed from

==========
Allow JS to intercept and override ServiceRegistry requests.

This adds the ability for users of ServiceRegistryImpl to
override remote service requests with local service factories,
a feature that is strictly intended to support sevice mocking
for tests.

This ability is in turn exposed via a new addServiceOverride
binding on the ServiceRegistry's JS interface.

Part of a CL series to enable Mojo service mocks in layout tests:

 1. https://codereview.chromium.org/1468903002
 2. https://codereview.chromium.org/1470823002
 4. this CL
==========

to

==========
[mojo] Enable ServiceRegistryImpl to override remote services

This adds a new AddServiceOverride method to ServiceRegistryImpl.
The purpose of this is to allow testing code to intercept remote
service connections and opaquely provide a mock implementation of
any service.

The new interface is also added to the ServiceRegistry's JS
bindings.
==========

[Ken Rockot(use gerrit already), 2016-01-26 16:24:42]

rockot@chromium.org changed reviewers:
+ jam@chromium.org

[jam, 2016-01-26 23:04:19]

lgtm for code outside blink. a blink reviewer should review the other parts

https://codereview.chromium.org/1470153002/diff/180001/content/common/mojo/se...
File content/common/mojo/service_registry_impl.h (right):

https://codereview.chromium.org/1470153002/diff/180001/content/common/mojo/se...
content/common/mojo/service_registry_impl.h:44: void AddServiceOverride(const
std::string& service_name,
add ForTesting method suffix to make presubmit checks ensure that it's only
called from tests

[Ken Rockot(use gerrit already), 2016-01-26 23:58:07]

rockot@chromium.org changed reviewers:
+ reillyg@chromium.org

[Ken Rockot(use gerrit already), 2016-01-26 23:58:07]

Thanks. Reilly would you mind taking a look at the layout test code?

https://codereview.chromium.org/1470153002/diff/180001/content/common/mojo/se...
File content/common/mojo/service_registry_impl.h (right):

https://codereview.chromium.org/1470153002/diff/180001/content/common/mojo/se...
content/common/mojo/service_registry_impl.h:44: void AddServiceOverride(const
std::string& service_name,
On 2016/01/26 at 23:04:19, jam wrote:
> add ForTesting method suffix to make presubmit checks ensure that it's only
called from tests

Done.

[Reilly Grant (use Gerrit), 2016-01-27 01:11:03]

Layout tests LGTM.

[Ken Rockot(use gerrit already), 2016-01-27 03:56:13]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-01-27 03:56:13]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1470153002/#ps220001
(title: " ")

[commit-bot: I haz the power, 2016-01-27 03:56:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1470153002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1470153002/220001

[commit-bot: I haz the power, 2016-01-27 05:21:27]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-01-27 05:22:17]

Description was changed from

==========
[mojo] Enable ServiceRegistryImpl to override remote services

This adds a new AddServiceOverride method to ServiceRegistryImpl.
The purpose of this is to allow testing code to intercept remote
service connections and opaquely provide a mock implementation of
any service.

The new interface is also added to the ServiceRegistry's JS
bindings.
==========

to

==========
[mojo] Enable ServiceRegistryImpl to override remote services

This adds a new AddServiceOverride method to ServiceRegistryImpl.
The purpose of this is to allow testing code to intercept remote
service connections and opaquely provide a mock implementation of
any service.

The new interface is also added to the ServiceRegistry's JS
bindings.

Committed: https://crrev.com/9b0d7173af550086d5688137752a6f70109e9c98
Cr-Commit-Position: refs/heads/master@{#371736}
==========

[commit-bot: I haz the power, 2016-01-27 05:22:18]

Patchset 12 (id:??) landed as
https://crrev.com/9b0d7173af550086d5688137752a6f70109e9c98
Cr-Commit-Position: refs/heads/master@{#371736}

[Noel Gordon, 2016-01-28 06:58:27]

No BUG=

[Noel Gordon, 2016-01-28 06:59:12]

On 2016/01/28 06:58:27, noel gordon wrote:
> No BUG=

Leaks on Oilpan as an FYI.

https://code.google.com/p/chromium/issues/detail?id=581987

[Noel Gordon, 2016-01-28 08:28:49]

A revert of this CL (patchset #12 id:220001) has been created in
https://codereview.chromium.org/1639233004/ by noel@chromium.org.

The reason for reverting is: Causing Oilpan leak bot failure

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...
.