Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1464373002: Move builtin Mojo JS modules out of WebUIDataDataSourceImpl (Closed)

Created:
5 years, 1 month ago by Ken Rockot(use gerrit already)
Modified:
4 years, 11 months ago
Reviewers:
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@usb-testing-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move builtin Mojo JS modules out of WebUIDataDataSourceImpl This makes Mojo JS modules available to any context where Mojo bindings are enabled. Part of a CL series to enable Mojo service mocks in layout tests: 1. https://codereview.chromium.org/1468903002 2. https://codereview.chromium.org/1470823002 3. this CL 4. https://codereview.chromium.org/1470153002

Patch Set 1 #

Patch Set 2 : update parent cl #

Patch Set 3 : merge #

Patch Set 4 : #

Patch Set 5 : self review #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -39 lines) Patch
M chrome/browser/ui/webui/engagement/site_engagement_ui.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_ui.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/webui/web_ui_data_source_impl.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/webui/web_ui_data_source_impl.cc View 1 2 3 4 5 2 chunks +0 lines, -19 lines 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 2 3 4 5 3 chunks +0 lines, -13 lines 0 comments Download
M content/public/browser/web_ui_data_source.h View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/mojo_context_state.cc View 1 2 3 4 5 4 chunks +55 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1470823002 Patch 100001

Dependent Patchsets:

Issue 1470153002 Patch 100001

Messages

Total messages: 2 (2 generated)
Ken Rockot(use gerrit already)
Description was changed from ========== Move builtin Mojo EDK JS modules out of WebUIDataDataSourceImpl This ...
5 years, 1 month ago (2015-11-23 23:30:30 UTC) #1
Ken Rockot(use gerrit already)
4 years, 11 months ago (2016-01-24 22:35:21 UTC) #2 
Description was changed from

==========
Move builtin Mojo EDK JS modules out of WebUIDataDataSourceImpl

This makes JS modules for core EDK components (router etc)
available to any context where Mojo bindings are available,
rather than only WebUI contexts.

Part of a CL series to enable Mojo service mocks in layout tests:

 1. https://codereview.chromium.org/1468903002
 2. https://codereview.chromium.org/1470823002
 3. this CL
 4. https://codereview.chromium.org/1470153002
==========

to

==========
Move builtin Mojo JS modules out of WebUIDataDataSourceImpl

This makes Mojo JS modules available to any context where
Mojo bindings are enabled.

Part of a CL series to enable Mojo service mocks in layout tests:

 1. https://codereview.chromium.org/1468903002
 2. https://codereview.chromium.org/1470823002
 3. this CL
 4. https://codereview.chromium.org/1470153002
==========

Powered by Google App Engine
This is Rietveld 408576698