Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1468903002: Rename some WebUI Mojo concepts to be more generic (Closed)

Created:
5 years ago by Ken Rockot(use gerrit already)
Modified:
5 years ago
Reviewers:
jam, sky
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename some WebUI Mojo concepts to be more generic This is just a mechanical rename, since there's no reason these bits need to be conceptually limited to WebUI usage. Part of a CL series to enable Mojo service mocks in layout tests: 1. this CL 2. https://codereview.chromium.org/1470823002 3. https://codereview.chromium.org/1464373002 4. https://codereview.chromium.org/1470153002 TBR=jam@chromium.org Committed: https://crrev.com/4a038f904fc285301fbd6dbf46c3394071eb3058 Cr-Commit-Position: refs/heads/master@{#361457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -636 lines) Patch
M content/content_renderer.gypi View 2 chunks +8 lines, -8 lines 0 comments Download
A + content/renderer/mojo_bindings_controller.h View 3 chunks +21 lines, -20 lines 0 comments Download
A + content/renderer/mojo_bindings_controller.cc View 4 chunks +35 lines, -33 lines 0 comments Download
A + content/renderer/mojo_context_state.h View 4 chunks +12 lines, -13 lines 0 comments Download
A + content/renderer/mojo_context_state.cc View 7 chunks +13 lines, -16 lines 0 comments Download
A + content/renderer/mojo_main_runner.h View 3 chunks +8 lines, -7 lines 0 comments Download
A + content/renderer/mojo_main_runner.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M content/renderer/render_view_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
D content/renderer/web_ui_mojo.h View 1 chunk +0 lines, -77 lines 0 comments Download
D content/renderer/web_ui_mojo.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D content/renderer/web_ui_mojo_context_state.h View 1 chunk +0 lines, -85 lines 0 comments Download
D content/renderer/web_ui_mojo_context_state.cc View 1 chunk +0 lines, -140 lines 0 comments Download
D content/renderer/web_ui_runner.h View 1 chunk +0 lines, -44 lines 0 comments Download
D content/renderer/web_ui_runner.cc View 1 chunk +0 lines, -56 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
Ken Rockot(use gerrit already)
Scott, could you please take a look as (IIRC) the original author of this stuff? ...
5 years ago (2015-11-24 02:19:20 UTC) #5
sky
LGTM
5 years ago (2015-11-24 16:18:57 UTC) #6
Ken Rockot(use gerrit already)
TBRing jam since it's just renames
5 years ago (2015-11-24 18:13:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468903002/1
5 years ago (2015-11-24 18:14:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 21:52:53 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4a038f904fc285301fbd6dbf46c3394071eb3058 Cr-Commit-Position: refs/heads/master@{#361457}
5 years ago (2015-11-24 21:53:47 UTC) #12
jam
5 years ago (2015-11-24 21:57:36 UTC) #13
Message was sent while issue was closed.
On 2015/11/24 18:13:29, Ken Rockot (OOO slow til 12-4) wrote:
> TBRing jam since it's just renames

lgtm

Powered by Google App Engine
This is Rietveld 408576698